OpenStudio CLI

[anyaelena]

Closes #269

[anyaelena]

Tests are passing but I've hardcoded the full path to the openstudio executable for both Windows and Linux/OSX. This seems like a bad idea, but does this code only run on workers with scripted configuration?

If we do not want to hardcode path to executable (and we probably don't), we should be able to either:

1. don't specify path but ensure included in PATH environment variable: This won't currently work on Linux/OSX, but it looks like may for newer versions of OpenStudio (this). Note that in Appveyor set up, it does not look like C:\projects\openstudio\bin is in PATH
2. Add a OPENSTUDIO_LOCATION ENV variable for all environments.

This begs the question: If we need to change ENV variables in the CI setup for our tests to pass, where else do we need to change them so that PAT doesn't break? What else should I consider?
@nllong @rHorsey

[anyaelena]

Also, per @nllong's comment on the related issue, i've set this to timeout after 2 hours.

[rHorsey]

@anyaelena Will the hardcoded path issue be fixed with the closure of NREL/OpenStudio#2911 ? If so, I'm happy to wait for OS 2.5.1 to be released & then rerun the tests & merge then if you are. Maybe also @macumber

[rHorsey]

Sorry - I can't help myself. I really love labels in github. I don't really know why.

[anyaelena]

@rHorsey I had to hardcode path to executable in for Windows as well, which is not a known OS bug.
I assume this is because the executable directory C:\projects\openstudio\bin was not in PATH. and then i also assume that is was not in PATH because calling openstudio via workflow gem leaned on this which in tern uses the RUBYLIB var (i actually don't see where this is used in the code, but it's clearly needed to point to the os ruby wrapper).

So:

1. OS update will probably remove hardcoded path requirement for Linux/OSX, since I observed exactly the issue that they have addressed.
2. updating PATH in Appveyor setup might allow tests to pass without hardcoded path to openstudio.exe. I will test this.
3. ?? I need someone to talk to me about how PAT/OSS work together so i can understand whether this is well tested with our CI and feel comfortable that requiring a change to PATH won't break this.

[anyaelena]

@shorowit would like to test this branch

[anyaelena]

@nllong @rHorsey does this error mean anything to you? we are getting it for unit tests in osx and linux

[rHorsey]

I'm building an AMI (2.6.1-rc2) off of this tonight so David can beat it up tomorrow with lots of gem switching.

[rHorsey]

AMI 2.6.1-cli0 has been built against 43291c4 for testing.

[rHorsey]

Handed off to @DavidGoldwasser to test 2.6.1-cli0

[DavidGoldwasser]

I have tested analysis finalization scripts on build of develop branch of PAT and a custom server setup. I was able to read from and write to the database.