2.7.1 unexpected return #443
Conversation
| @@ -6,4 +6,5 @@ echo "Waiting for Mongo to start" | |||
| echo "Waiting for Redis to start" | |||
| /usr/local/bin/wait-for-it --strict -t 0 queue:6379 | |||
|
|
|||
| cd /opt/openstudio/server && bundle exec rake environment resque:workers | |||
| # Only start a single worker when calling this script (do not use resque:workers). | |||
There was a problem hiding this comment.
if this is appropriate, we should rename the script (which is start-workers.sh). but is it used for for worker node setup as well as web-background?
There was a problem hiding this comment.
Yeah, start-workers.sh only starts a single worker instance and registers it with redis. This was probably causing an issue because in docker-compose.yml (for local use) had COUNT=1 set then called resque:workers. Let me know if you want me to rename before merging.
There was a problem hiding this comment.
preference for renaming but not required.
| @@ -76,4 +76,7 @@ | |||
|
|
|||
| # Use a different logger for distributed setups. | |||
| # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new) | |||
|
|
|||
| # TODO: Remove assumption that we are developing on a machine that has which installed! Make cross platform... | |||
| config.os_gemfile_path = File.expand_path(File.join(File.dirname(`which openstudio`), '../Ruby')) | |||
There was a problem hiding this comment.
i think this will fail on windows. also, it will trigger the --bundle options to be passed with openstudio cli call, which should only happen if the bundle has been installed locally and we do not want to use what comes packaged with openstudio
There was a problem hiding this comment.
This will fail on windows, but I'm assuming that no one is developing on windows (or running the development.rb environment. That was the essence of my TODO comment.
There was a problem hiding this comment.
I guess i'm more concerned with introduction of requirement that bundle install be run locally for the openstudio install. what is this getting us?
There was a problem hiding this comment.
i have approved this pr, but for the record i think that at a minimum a very explicit comment about the bundle install requirement will help us in the future. or commit with this commented out and the explanation to uncomment if you want to run with a locally installed openstudio bundle.
| @@ -6,4 +6,5 @@ echo "Waiting for Mongo to start" | |||
| echo "Waiting for Redis to start" | |||
| /usr/local/bin/wait-for-it --strict -t 0 queue:6379 | |||
|
|
|||
| cd /opt/openstudio/server && bundle exec rake environment resque:workers | |||
| # Only start a single worker when calling this script (do not use resque:workers). | |||
There was a problem hiding this comment.
preference for renaming but not required.
nllong
force-pushed
the
2.7.1-unexpected-return
branch
from
c3808ae
to
eb43eb9
Compare
.travis.yml
Outdated
| @@ -13,7 +13,7 @@ gemfile: | |||
|
|
|||
| # Set the default scripts that are used for the majority of the tests in the matrix | |||
| before_install: | |||
| - ./ci/travis/setup.sh | |||
| - travis_wait ./ci/travis/setup.sh | |||
nllong
force-pushed
the
2.7.1-unexpected-return
branch
4 times, most recently
from
336ec66
to
61fc630
Compare
nllong
force-pushed
the
2.7.1-unexpected-return
branch
from
61fc630
to
7d4e528
Compare
When launching the rake commands, there was an 'unexpected return' that appeared in the command line. It was caused by calling
openstudio openstudio_versionin the environment files. This was setting the os_version, but was never used.