-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.7.1 unexpected return #443
Changes from 5 commits
55fbd02
538e421
e20e19b
3108ce7
eb43eb9
7d4e528
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,5 @@ echo "Waiting for Mongo to start" | |
echo "Waiting for Redis to start" | ||
/usr/local/bin/wait-for-it --strict -t 0 queue:6379 | ||
|
||
cd /opt/openstudio/server && bundle exec rake environment resque:workers | ||
# Only start a single worker when calling this script (do not use resque:workers). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if this is appropriate, we should rename the script (which is start-workers.sh). but is it used for for worker node setup as well as web-background? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, start-workers.sh only starts a single worker instance and registers it with redis. This was probably causing an issue because in docker-compose.yml (for local use) had COUNT=1 set then called resque:workers. Let me know if you want me to rename before merging. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. preference for renaming but not required. |
||
cd /opt/openstudio/server && bundle exec rake environment resque:work |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,4 +76,7 @@ | |
|
||
# Use a different logger for distributed setups. | ||
# config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new) | ||
|
||
# TODO: Remove assumption that we are developing on a machine that has which installed! Make cross platform... | ||
config.os_gemfile_path = File.expand_path(File.join(File.dirname(`which openstudio`), '../Ruby')) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think this will fail on windows. also, it will trigger the --bundle options to be passed with openstudio cli call, which should only happen if the bundle has been installed locally and we do not want to use what comes packaged with openstudio There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will fail on windows, but I'm assuming that no one is developing on windows (or running the development.rb environment. That was the essence of my TODO comment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess i'm more concerned with introduction of requirement that bundle install be run locally for the openstudio install. what is this getting us? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i have approved this pr, but for the record i think that at a minimum a very explicit comment about the bundle install requirement will help us in the future. or commit with this commented out and the explanation to uncomment if you want to run with a locally installed openstudio bundle. |
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!