Worker Init/Final Log on Datapoint #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyaelena
approved these changes
Apr 30, 2019
|
|
||
| # First check if there is a file that indicates the gem has already been updated. | ||
| # We only need to update the bundle once / worker, not every time a data point is initialized. | ||
| echo "Checking if Gemfile has been updated in ${GEMFILEUPDATE}" |
There was a problem hiding this comment.
should we do this at the start?
There was a problem hiding this comment.
yeah, that would make more sense.
| ensure | ||
| # save the log information to the datapoint if it exists | ||
| if File.exist? log_path | ||
| @data_point.worker_logs[script_name] = File.read(log_path).lines |
There was a problem hiding this comment.
i like this update. the logs are also downloaded w/data point zip file.
| Project.destroy_all | ||
| Delayed::Job.destroy_all | ||
| rescue Errno::EACCES => e | ||
| puts "Cannot unlink files, will try and continue" |
|
Thanks @nllong! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon merging have this page reference the script in the PR.