Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example_08.py #185

Closed
wants to merge 1 commit into from
Closed

Update example_08.py #185

wants to merge 1 commit into from

Conversation

aclerc
Copy link
Contributor

@aclerc aclerc commented Nov 24, 2022

Remove tmin so that entire simulation is plotted. Removing tmin=10 because with that setting only the final timestep of the simulation is loaded.

Description and Purpose

Before this change I was getting this plot when running example_08 which confused me because it appeared to be empty:
before

After comparing the variable fastout to IEA-15-240-RWT-UMaineSemi.out I realized only the last row of the file was being loaded and plotted. I tried removing tmin=10 and that worked. The plot after this change:
after

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

Remove tmin so that entire simulation is plotted. Removing tmin=10 because with that setting only the final timestep of the simulation is loaded
@dzalkind
Copy link
Collaborator

Thanks for contributing to this fix. I have merged it into #188 and it will make its way into develop soon.

@dzalkind dzalkind closed this Nov 29, 2022
@aclerc aclerc deleted the fix-example_08 branch December 15, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants