Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Bug Fixes #188

Merged
merged 23 commits into from
Dec 12, 2022
Merged

Various Bug Fixes #188

merged 23 commits into from
Dec 12, 2022

Conversation

dzalkind
Copy link
Collaborator

Description and Purpose

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

dzalkind and others added 14 commits October 4, 2022 13:54
@dzalkind
Fix yaw threshold documentation in DISCON
99a5ebe
@dzalkind
Fix debug unit labels
657f206
@dzalkind
Add nacelle heading error to DebugVar
537e336
@dzalkind
Update ROSCO_IO and Types
46176fd
@dzalkind
Read NacHeading from OpenFAST
a6d4d90
@dzalkind
Update DISCONs
35f2911
@dzalkind
Fix ******s in dbg files
cfe7b5b
@dzalkind
Allow single U in power_curve
1c15a8b
@dzalkind
Initialize floating feedback filters at 0, make optional input for filts
458925f
@dzalkind
give dummy units if dbg units missing
9780e9a
@aclerc
Update FAST_wrapper.py
e92bc30 
Fix UnboundLocalError: local variable 'e' referenced before assignment
@aclerc
Update example_08.py
6dc4f18 
Remove tmin so that entire simulation is plotted. Removing tmin=10 because with that setting only the final timestep of the simulation is loaded
@dzalkind
Update linear_model handling for new pyFAST, will break with weis import
a9a2a0b
@dzalkind
Merge remote-tracking branch 'upstream/develop' into vbf
de951b5
@dzalkind dzalkind mentioned this pull request Nov 28, 2022
Closed
This was referenced Nov 29, 2022
Closed
Closed
@dzalkind dzalkind mentioned this pull request Nov 29, 2022
Closed
14 tasks
@dzalkind dzalkind mentioned this pull request Dec 9, 2022
Closed
@dzalkind dzalkind mentioned this pull request Dec 9, 2022
Closed
@dzalkind
Copy link
Collaborator Author

dzalkind commented Dec 9, 2022

Tests, compared with #167

comp_outputs.pdf

@dzalkind dzalkind merged commit 602332e into NREL:develop Dec 12, 2022
@aclerc aclerc mentioned this pull request Dec 15, 2022
Merged
14 tasks
@dzalkind dzalkind deleted the vbf branch March 17, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzalkind @aclerc