New Molten Salt Linear Fresnel Model and IPH #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tanks and hx logic
Remove 'no financial' options in UI.
…s flow rate. Fix Aux calculation in system control'
…a_price_input variable type. Modify merchant default file. Remove unnecessary dispatch optimization UI field. Set correct opt_type in default files
… Synchronize defaults with old molten salt linear fresnel model and trough model for dispatch
…ispatch factors to single array
…SS receiver and header heat loss to UI. Add piping summary to notices
cpaulgilman
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
This looks good. A couple of comments:
- Should we use "Industrial Process Heat" instead of "Heat" in the configuration chooser? "Heat" is a little ambiguous.
- I get a callback error when I try to open a file with a default MSLF / Single Owner case created by SAM 2022.11.21 r3. This may be something we could resolve after merging into Develop.
cpaulgilman
added
the
requires help revision
tyneises
approved these changes
Sep 15, 2023
Use configopt() approach from Hybrids branch to create `tree_parent` in startup.lk. Rename "Heat" category to "Industrial Process Heat".
cpaulgilman
added
the
added to release notes
cpaulgilman
removed
the
requires help revision
cpaulgilman
added a commit
that referenced
this pull request
Dec 7, 2024
Grid limits do not affect electricity imports from the grid. Revise IPH molten salt linear Fresnel topics Power tower heliostast pivot point height definition. New Financial Parameters topic for LCOH Calculator. Wind wake loss inputs NREL/ssc#1186 Annual energy and monthly energy label updates: NREL/ssc#1236 Replace parentheses with commas for installation cost units Battery availability loss. NREL/ssc#1241 Tidal Energy Converter page revisions for new options, see #1807. New net billing with carryover options. NREL/ssc#1200 IPH MSLF revisions: #1444 Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf. PV GCR affects output for bifacial modules. Revise report generator topic to explain template not available for some configurations. Add topics for IPH financial models Generic system to custom generatio profile Standalone battery time step New autographs and default graphs for battery configurations: #1884 System Availability three hour option for marine, "hourly" to "time series" ## October 24, 2024 Update Cambium note about years for Cambium 2023 Battery dispatch (BTM and FOM) battery can charge from grid-limited system power Grid limits battery can charge from grid-limited system power Project with 100% debt results in IRR = NaN Revise real discount rate description Geothermal system availability losses Revise metrics topics to facilitate navigation. Revise weather file format to include CSV for wind Revise PV subhourly clipping "Allen method" Revise Cost of Acquiring Financing.
15 tasks
cpaulgilman
added a commit
that referenced
this pull request
Dec 10, 2024
* Help revisions for SAM 2024.12.12 Grid limits do not affect electricity imports from the grid. Revise IPH molten salt linear Fresnel topics Power tower heliostast pivot point height definition. New Financial Parameters topic for LCOH Calculator. Wind wake loss inputs NREL/ssc#1186 Annual energy and monthly energy label updates: NREL/ssc#1236 Replace parentheses with commas for installation cost units Battery availability loss. NREL/ssc#1241 Tidal Energy Converter page revisions for new options, see #1807. New net billing with carryover options. NREL/ssc#1200 IPH MSLF revisions: #1444 Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf. PV GCR affects output for bifacial modules. Revise report generator topic to explain template not available for some configurations. Add topics for IPH financial models Generic system to custom generatio profile Standalone battery time step New autographs and default graphs for battery configurations: #1884 System Availability three hour option for marine, "hourly" to "time series" ## October 24, 2024 Update Cambium note about years for Cambium 2023 Battery dispatch (BTM and FOM) battery can charge from grid-limited system power Grid limits battery can charge from grid-limited system power Project with 100% debt results in IRR = NaN Revise real discount rate description Geothermal system availability losses Revise metrics topics to facilitate navigation. Revise weather file format to include CSV for wind Revise PV subhourly clipping "Allen method" Revise Cost of Acquiring Financing. * Help revisions Revise "receiver startup delay time" and "receiver startup delay energy fraction" descriptions for trough and Fresnel models. Fix remaining references to "generic system" model. --------- Co-authored-by: Steven Janzou <steven@janzouconsulting.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overhauled the molten salt linear fresnel model. Now uses the same CSP controller and solver as the power tower and parabolic trough models. Added mslf IPH model. Removed old molten salt linear fresnel model.
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.