New Wind Features 2024 #1186
Merged
New Wind Features 2024 #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del, renamed wake loss variables and outputs for clarity
…ovide additional values
…and updated test accordingly
…r the park wake model. placeholder for functionality of using the input needs to be updated.
…ve to belong to wind turbine class so that it will be available to all wake models
…h a user-defined Ct curve for all wind wake models
…update wake loss output names per Paul suggestions
… needs to be completed
…re than just the timestep triggering the loss
dguittet
reviewed
Jul 30, 2024
dguittet
requested changes
Jul 30, 2024
…e model option and updated tests accordingly
dguittet
reviewed
Oct 14, 2024
cpaulgilman
added a commit
to NREL/SAM
that referenced
this pull request
Dec 7, 2024
Grid limits do not affect electricity imports from the grid. Revise IPH molten salt linear Fresnel topics Power tower heliostast pivot point height definition. New Financial Parameters topic for LCOH Calculator. Wind wake loss inputs NREL/ssc#1186 Annual energy and monthly energy label updates: NREL/ssc#1236 Replace parentheses with commas for installation cost units Battery availability loss. NREL/ssc#1241 Tidal Energy Converter page revisions for new options, see #1807. New net billing with carryover options. NREL/ssc#1200 IPH MSLF revisions: #1444 Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf. PV GCR affects output for bifacial modules. Revise report generator topic to explain template not available for some configurations. Add topics for IPH financial models Generic system to custom generatio profile Standalone battery time step New autographs and default graphs for battery configurations: #1884 System Availability three hour option for marine, "hourly" to "time series" ## October 24, 2024 Update Cambium note about years for Cambium 2023 Battery dispatch (BTM and FOM) battery can charge from grid-limited system power Grid limits battery can charge from grid-limited system power Project with 100% debt results in IRR = NaN Revise real discount rate description Geothermal system availability losses Revise metrics topics to facilitate navigation. Revise weather file format to include CSV for wind Revise PV subhourly clipping "Allen method" Revise Cost of Acquiring Financing.
15 tasks
cpaulgilman
added a commit
to NREL/SAM
that referenced
this pull request
Dec 10, 2024
* Help revisions for SAM 2024.12.12 Grid limits do not affect electricity imports from the grid. Revise IPH molten salt linear Fresnel topics Power tower heliostast pivot point height definition. New Financial Parameters topic for LCOH Calculator. Wind wake loss inputs NREL/ssc#1186 Annual energy and monthly energy label updates: NREL/ssc#1236 Replace parentheses with commas for installation cost units Battery availability loss. NREL/ssc#1241 Tidal Energy Converter page revisions for new options, see #1807. New net billing with carryover options. NREL/ssc#1200 IPH MSLF revisions: #1444 Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf. PV GCR affects output for bifacial modules. Revise report generator topic to explain template not available for some configurations. Add topics for IPH financial models Generic system to custom generatio profile Standalone battery time step New autographs and default graphs for battery configurations: #1884 System Availability three hour option for marine, "hourly" to "time series" ## October 24, 2024 Update Cambium note about years for Cambium 2023 Battery dispatch (BTM and FOM) battery can charge from grid-limited system power Grid limits battery can charge from grid-limited system power Project with 100% debt results in IRR = NaN Revise real discount rate description Geothermal system availability losses Revise metrics topics to facilitate navigation. Revise weather file format to include CSV for wind Revise PV subhourly clipping "Allen method" Revise Cost of Acquiring Financing. * Help revisions Revise "receiver startup delay time" and "receiver startup delay energy fraction" descriptions for trough and Fresnel models. Fix remaining references to "generic system" model. --------- Co-authored-by: Steven Janzou <steven@janzouconsulting.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a variety of new features to the wind model, currently accessible only programmatically.
New features include:
--also separates "internal" wake losses (i.e. calculated by a wake model) from external wake losses (i.e. from other plants)
Tests have been added to cover these new features.
Bug fix for #1143 included in this PR.
@dguittet I think you're the best reviewer for this, but note that this is not an urgent PR. :) I did not generate the the new API files for these new inputs, but maybe I can get your help with that when you have some time?