Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

economizer implementation changes #1555

Merged
merged 6 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/openstudio-standards.rb
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,6 @@ module OpenstudioStandards
require_relative "#{proto}/ashrae_90_1/nrel_nze_ready_2017/nrel_zne_ready_2017.FanOnOff"
require_relative "#{proto}/ashrae_90_1/nrel_nze_ready_2017/nrel_zne_ready_2017.FanVariableVolume"
require_relative "#{proto}/ashrae_90_1/nrel_nze_ready_2017/nrel_zne_ready_2017.HeatExchangerAirToAirSensibleAndLatent"
require_relative "#{proto}/ashrae_90_1/nrel_nze_ready_2017/nrel_zne_ready_2017.Model"
require_relative "#{proto}/ashrae_90_1/nrel_nze_ready_2017/nrel_zne_ready_2017.Model.elevators"
require_relative "#{proto}/ashrae_90_1/nrel_nze_ready_2017/nrel_zne_ready_2017.hvac_systems"
# ZE AEDG Multifamily
Expand Down
Original file line number Diff line number Diff line change
@@ -1,38 +1,6 @@
class ASHRAE9012016 < ASHRAE901
# @!group Model

# Determine the prototypical economizer type for the model.
#
# @param model [OpenStudio::Model::Model] OpenStudio model object
# @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
# @return [String] the economizer type. Possible values are:
# 'NoEconomizer'
# 'FixedDryBulb'
# 'FixedEnthalpy'
# 'DifferentialDryBulb'
# 'DifferentialEnthalpy'
# 'FixedDewPointAndDryBulb'
# 'ElectronicEnthalpy'
# 'DifferentialDryBulbAndEnthalpy'
def model_economizer_type(model, climate_zone)
economizer_type = case climate_zone
when 'ASHRAE 169-2006-0A',
'ASHRAE 169-2006-1A',
'ASHRAE 169-2006-2A',
'ASHRAE 169-2006-3A',
'ASHRAE 169-2006-4A',
'ASHRAE 169-2013-0A',
'ASHRAE 169-2013-1A',
'ASHRAE 169-2013-2A',
'ASHRAE 169-2013-3A',
'ASHRAE 169-2013-4A'
'DifferentialEnthalpy'
else
'DifferentialDryBulb'
end
return economizer_type
end

# Adjust model to comply with fenestration orientation requirements
# @note code_sections [90.1-2013_5.5.4.5]
#
Expand Down Expand Up @@ -299,7 +267,7 @@ def model_add_lights_shutoff(model)
end

# guard clause to skip space with no lights
next if space_lights.empty?
next if space_lights.empty?

# if lights are defined at the space type level, clone each lights object and make it individual to the space
new_space_lights = []
Expand Down
Original file line number Diff line number Diff line change
@@ -1,38 +1,6 @@
class ASHRAE9012019 < ASHRAE901
# @!group Model

# Determine the prototypical economizer type for the model.
#
# @param model [OpenStudio::Model::Model] OpenStudio model object
# @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
# @return [String] the economizer type. Possible values are:
# 'NoEconomizer'
# 'FixedDryBulb'
# 'FixedEnthalpy'
# 'DifferentialDryBulb'
# 'DifferentialEnthalpy'
# 'FixedDewPointAndDryBulb'
# 'ElectronicEnthalpy'
# 'DifferentialDryBulbAndEnthalpy'
def model_economizer_type(model, climate_zone)
economizer_type = case climate_zone
when 'ASHRAE 169-2006-0A',
'ASHRAE 169-2006-1A',
'ASHRAE 169-2006-2A',
'ASHRAE 169-2006-3A',
'ASHRAE 169-2006-4A',
'ASHRAE 169-2013-0A',
'ASHRAE 169-2013-1A',
'ASHRAE 169-2013-2A',
'ASHRAE 169-2013-3A',
'ASHRAE 169-2013-4A'
'DifferentialEnthalpy'
else
'DifferentialDryBulb'
end
return economizer_type
end

# Adjust model to comply with fenestration orientation requirements
# @note code_sections [90.1-2013_5.5.4.5]
#
Expand Down Expand Up @@ -299,7 +267,7 @@ def model_add_lights_shutoff(model)
end

# guard clause to skip space with no lights
next if space_lights.empty?
next if space_lights.empty?

# if lights are defined at the space type level, clone each lights object and make it individual to the space
new_space_lights = []
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2474,7 +2474,13 @@ def model_multiply_schedule(model, day_sch, multiplier, limit)
# end reduce schedule

# Determine the prototypical economizer type for the model.
# Defaults to the pre-90.1-2010 assumption of DifferentialDryBulb.
# Defaults to FixedDryBulb based on anecdotal evidence of this being
# the most common type encountered in the field, combined
# with this being the default option for many equipment manufacturers,
# and being the strategy recommended in the 2010 ASHRAE journal article
# "Economizer High Limit Devices and Why Enthalpy Economizers Don't Work"
# by Steven Taylor and Hwakong Cheng.
# https://tayloreng.egnyte.com/dl/mN0c9t4WSO/ASHRAE_Journal_-_Economizer_High_Limit_Devices_and_Why_Enthalpy_Economizers_Dont_Work.pdf_
#
# @param model [OpenStudio::Model::Model] the model
# @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
Expand All @@ -2488,7 +2494,7 @@ def model_multiply_schedule(model, day_sch, multiplier, limit)
# 'ElectronicEnthalpy'
# 'DifferentialDryBulbAndEnthalpy'
def model_economizer_type(model, climate_zone)
economizer_type = 'DifferentialDryBulb'
economizer_type = 'FixedDryBulb'
return economizer_type
end

Expand Down
6 changes: 6 additions & 0 deletions lib/openstudio-standards/standards/Standards.AirLoopHVAC.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1060,6 +1060,12 @@ def air_loop_hvac_apply_economizer_limits(air_loop_hvac, climate_zone)
oa_control.setEconomizerMaximumLimitDryBulbTemperature(drybulb_limit_c)
OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}: Economizer type = #{economizer_type}, dry bulb limit = #{drybulb_limit_f}F")
end
# Some templates include fixed enthalpy limits in addition to fixed dry bulb limits
if enthalpy_limit_btu_per_lb
enthalpy_limit_j_per_kg = OpenStudio.convert(enthalpy_limit_btu_per_lb, 'Btu/lb', 'J/kg').get
oa_control.setEconomizerMaximumLimitEnthalpy(enthalpy_limit_j_per_kg)
OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "For #{air_loop_hvac.name}: additional economizer enthalpy limit = #{enthalpy_limit_btu_per_lb}Btu/lb")
end
when 'FixedEnthalpy'
if enthalpy_limit_btu_per_lb
enthalpy_limit_j_per_kg = OpenStudio.convert(enthalpy_limit_btu_per_lb, 'Btu/lb', 'J/kg').get
Expand Down
109 changes: 85 additions & 24 deletions lib/openstudio-standards/standards/deer/deer.AirLoopHVAC.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,83 @@ def air_loop_hvac_unoccupied_fan_shutoff_required?(air_loop_hvac)
return shutoff_required
end

# Determine whether or not this system is required to have an economizer.
# Logic inferred from MASControl3 INP files and parameters database.
#
# @param air_loop_hvac [OpenStudio::Model::AirLoopHVAC] air loop
# @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
# @return [Bool] returns true if an economizer is required, false if not
def air_loop_hvac_economizer_required?(air_loop_hvac, climate_zone)
economizer_required = false

# skip systems without outdoor air
return economizer_required unless air_loop_hvac.airLoopHVACOutdoorAirSystem.is_initialized

# Determine if the airloop serves any computer rooms
# / data centers, which changes the economizer.
is_dc = false
if air_loop_hvac_data_center_area_served(air_loop_hvac) > 0
is_dc = true
end

# Retrieve economizer limits from JSON
search_criteria = {
'template' => template,
'climate_zone' => climate_zone,
'data_center' => is_dc
}
econ_limits = model_find_object(standards_data['economizers'], search_criteria)
if econ_limits.nil?
OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "Cannot find economizer limits for template '#{template}' and climate zone '#{climate_zone}', assuming no economizer required.")
return economizer_required
end

# Determine the minimum capacity and whether or not it is a data center
minimum_capacity_btu_per_hr = econ_limits['capacity_limit']

# A big number of btu per hr as the minimum requirement if nil in spreadsheet
infinity_btu_per_hr = 999_999_999_999
minimum_capacity_btu_per_hr = infinity_btu_per_hr if minimum_capacity_btu_per_hr.nil?

# Check whether the system requires an economizer by comparing
# the system capacity to the minimum capacity.
total_cooling_capacity_w = air_loop_hvac_total_cooling_capacity(air_loop_hvac)
total_cooling_capacity_btu_per_hr = OpenStudio.convert(total_cooling_capacity_w, 'W', 'Btu/hr').get

# Check whether the system has chilled water cooling
has_chilled_water_cooling = false
air_loop_hvac.supplyComponents.each do |equip|
if equip.to_CoilCoolingWater.is_initialized
has_chilled_water_cooling = true
end
end

# Applicability logic from MASControl3
if has_chilled_water_cooling
# All systems with chilled water cooling get an economizer regardless of capacity
OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "#{air_loop_hvac.name} requires an economizer because it has chilled water cooling.")
economizer_required = true
else
# DX and other systems may have a capacity limit
if total_cooling_capacity_btu_per_hr >= minimum_capacity_btu_per_hr
if is_dc
OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "#{air_loop_hvac.name} requires an economizer because the total cooling capacity of #{total_cooling_capacity_btu_per_hr.round} Btu/hr exceeds the minimum capacity of #{minimum_capacity_btu_per_hr.round} Btu/hr for data centers.")
else
OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "#{air_loop_hvac.name} requires an economizer because the total cooling capacity of #{total_cooling_capacity_btu_per_hr.round} Btu/hr exceeds the minimum capacity of #{minimum_capacity_btu_per_hr.round} Btu/hr.")
end
economizer_required = true
else
if is_dc
OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "#{air_loop_hvac.name} does not require an economizer because the total cooling capacity of #{total_cooling_capacity_btu_per_hr.round} Btu/hr is less than the minimum capacity of #{minimum_capacity_btu_per_hr.round} Btu/hr for data centers.")
else
OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.AirLoopHVAC', "#{air_loop_hvac.name} does not require an economizer because the total cooling capacity of #{total_cooling_capacity_btu_per_hr.round} Btu/hr is less than the minimum capacity of #{minimum_capacity_btu_per_hr.round} Btu/hr.")
end
end
end

return economizer_required
end

# Check the economizer type currently specified in the ControllerOutdoorAir object on this air loop
# is acceptable per the standard. Based on the MASControl rules, it appears that
# only NoEconomizer and FixedDryBulb are allowed.
Expand Down Expand Up @@ -48,6 +125,7 @@ def air_loop_hvac_economizer_type_allowable?(air_loop_hvac, climate_zone)
end

# Determine the limits for the type of economizer present on the AirLoopHVAC, if any.
# Enthalpy limit is from MASControl3.
#
# @param air_loop_hvac [OpenStudio::Model::AirLoopHVAC] air loop
# @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
Expand All @@ -59,7 +137,7 @@ def air_loop_hvac_economizer_limits(air_loop_hvac, climate_zone)

# Get the OA system and OA controller
oa_sys = air_loop_hvac.airLoopHVACOutdoorAirSystem
return [nil, nil, nil] unless oa_sys.is_initialized # No OA system
return [nil, nil, nil] unless oa_sys.is_initialized

oa_sys = oa_sys.get
oa_control = oa_sys.getControllerOutdoorAir
Expand All @@ -70,29 +148,12 @@ def air_loop_hvac_economizer_limits(air_loop_hvac, climate_zone)
return [nil, nil, nil]
when 'FixedDryBulb'
enthalpy_limit_btu_per_lb = 28
case climate_zone
when 'CEC T24-CEC7'
drybulb_limit_f = 69
when 'CEC T24-CEC1',
'CEC T24-CEC3',
'CEC T24-CEC5'
drybulb_limit_f = 70
when 'CEC T24-CEC6',
'CEC T24-CEC8',
'CEC T24-CEC9'
drybulb_limit_f = 71
when 'CEC T24-CEC2',
'CEC T24-CEC4',
'CEC T24-CEC10',
drybulb_limit_f = 73
when 'CEC T24-CEC11',
'CEC T24-CEC12',
'CEC T24-CEC13',
'CEC T24-CEC14',
'CEC T24-CEC15',
'CEC T24-CEC16'
drybulb_limit_f = 75
end
search_criteria = {
'template' => template,
'climate_zone' => climate_zone
}
econ_limits = model_find_object(standards_data['economizers'], search_criteria)
drybulb_limit_f = econ_limits['fixed_dry_bulb_high_limit_shutoff_temp']
end

return [drybulb_limit_f, enthalpy_limit_btu_per_lb, dewpoint_limit_f]
Expand Down
Loading