Building Energy Standards Chiller Data Update #1676
Conversation
lymereJ
changed the title
| @@ -343,13 +343,13 @@ def hspf_to_cop_heating_with_fan(hspf) | |||
| # @param eer [Double] Energy Efficiency Ratio (EER) | |||
| # @param capacity_w [Double] the heating capacity at AHRI rating conditions, in W | |||
| # @return [Double] Coefficient of Performance (COP) | |||
| def eer_to_cop(eer, capacity_w = nil) | |||
| def eer_to_cop_no_fan(eer, capacity_w = nil) | |||
There was a problem hiding this comment.
These functions were mislabeled. They did not correspond to a straight EER to COP conversion but rather excluded the effect of the fan when doing the conversion.
| if capacity_w.nil? | ||
| # The PNNL Method. | ||
| # r is the ratio of supply fan power to total equipment power at the rating condition, | ||
| # assumed to be 0.12 for the reference buildings per PNNL. | ||
| r = 0.12 | ||
| cop = (eer / 3.413 + r) / (1 - r) | ||
| cop = (eer / OpenStudio.convert(1.0, 'W', 'Btu/h').get + r) / (1 - r) |
There was a problem hiding this comment.
Use the convert function of OS to get additional precision.
| # | ||
| # @param cop [Double] Energy Efficiency Ratio (EER) | ||
| # @return [Double] Coefficient of Performance (COP) | ||
| def eer_to_cop(eer) |
There was a problem hiding this comment.
Add new function to do a straight EER to COP conversion.
| @@ -1138,6 +1138,7 @@ def model_set_central_preheat_coil_spm(model, thermal_zones, coil) | |||
| setpoint_sch = tstat.heatingSetpointTemperatureSchedule | |||
| setpoint_c = OpenstudioStandards::Schedules.schedule_get_design_day_min_max(setpoint_sch.get, 'winter')['max'] | |||
| next if setpoint_c.nil? | |||
|
|
|||
|
Several tests are failing because the |
|
Thanks, I'll take a look. I should have set the status to draft, it was not yet ready for review. Sorry. |
| elsif cap_tons > 300 && cap_tons < 600 | ||
| num_chillers = 2 | ||
| chiller_cooling_type = 'WaterCooled' | ||
| chiller_compressor_type = 'Rotary Screw and Scroll' | ||
| chiller_compressor_type = 'Rotary Screw' |
There was a problem hiding this comment.
@weilixu - There are a few PRM related changes.
|
@mdahlhausen - I think this is finally ready for review. The tests for the penultimate commit passed, the tests for the last one should pass as well (seem to pass locally). |
| @@ -14,16 +14,17 @@ def chiller_electric_eir_apply_efficiency_and_curves(chiller_electric_eir) | |||
|
|
|||
| # Set the efficiency value | |||
| cop = chiller_electric_eir_standard_minimum_full_load_efficiency(chiller_electric_eir) | |||
| kw_per_ton = cop_to_kw_per_ton(cop) | |||
| if cop.nil? | |||
There was a problem hiding this comment.
rubocop is suggesting guard clause format here:
unless cop
# log stuff
return false
end
There was a problem hiding this comment.
Thanks for the refactor of the chiller data. Two comments:
-
Please update from the master branch. You will need to generate the regression models again, as those changed with recent updates to master.
-
I understand the need to remove curves from the data .jsons and put them behind methods in standards instead. That may end up being the best approach, but I'm curious what other options you considered. In general, it'd be nice to have data elements in data files (perhaps a separate, static, chiller_curves.json), but could be (easily) convinced of your approach.
|
@mdahlhausen - Thanks for the review!
Looks like the tests are passing! |
Updates have been made to the Building Energy Standards Data repository, see here. This pull request was automatically generated.