-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building Energy Standards Chiller Data Update #1676
Merged
Merged
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3632d95
data_update (chiller_only) 4b6a008
leijerry888 97a42f6
Update chiller data lookup.
lymereJ cf3efbd
Remove references to kW/ton.
lymereJ 8ff9041
Clean unique fields.
lymereJ 5d51cca
Address test failures.
lymereJ 8ff178b
Handle curves assignement for chillers.
lymereJ 73da609
Add references.
lymereJ ab899f7
Add decimal places to kW/ton.
lymereJ b071323
Merge branch 'master' into data_update_4b6a008
lymereJ 66cf729
Merge branch 'master' into data_update_4b6a008
lymereJ 481bdb9
Updates test.
lymereJ 2b744dc
Add missing require statement. Not sure when it got removed...
lymereJ ea5ef2a
Update NECB test results.
lymereJ 2aa72ef
Merge branch 'master' into data_update_4b6a008
5ff9a8a
Update performance tests.
lymereJ 6765cd7
Add conversion from COP to EER as well.
lymereJ 1825bbe
Merge branch 'master' into data_update_4b6a008
lymereJ ff4c8c6
Guard close.
lymereJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -281,7 +281,7 @@ def cop_to_seer_cooling_no_fan(cop) | |
# @return [Double] Coefficient of Performance (COP) | ||
def seer_to_cop_cooling_with_fan(seer) | ||
eer = -0.0182 * seer * seer + 1.1088 * seer | ||
cop = (eer / 3.413 + 0.12) / (1 - 0.12) | ||
cop = (eer / OpenStudio.convert(1.0, 'W', 'Btu/h').get + 0.12) / (1 - 0.12) | ||
|
||
return cop | ||
end | ||
|
@@ -292,7 +292,7 @@ def seer_to_cop_cooling_with_fan(seer) | |
# @param cop [Double] Coefficient of Performance (COP) | ||
# @return [Double] seasonal energy efficiency ratio (SEER) | ||
def cop_to_seer_cooling_with_fan(cop) | ||
eer = cop_to_eer(cop) | ||
eer = cop_to_eer_no_fan(cop) | ||
delta = 1.1088**2 - 4.0 * 0.0182 * eer | ||
seer = (1.1088 - delta**0.5) / (2.0 * 0.0182) | ||
|
||
|
@@ -343,13 +343,13 @@ def hspf_to_cop_heating_with_fan(hspf) | |
# @param eer [Double] Energy Efficiency Ratio (EER) | ||
# @param capacity_w [Double] the heating capacity at AHRI rating conditions, in W | ||
# @return [Double] Coefficient of Performance (COP) | ||
def eer_to_cop(eer, capacity_w = nil) | ||
def eer_to_cop_no_fan(eer, capacity_w = nil) | ||
if capacity_w.nil? | ||
# The PNNL Method. | ||
# r is the ratio of supply fan power to total equipment power at the rating condition, | ||
# assumed to be 0.12 for the reference buildings per PNNL. | ||
r = 0.12 | ||
cop = (eer / 3.413 + r) / (1 - r) | ||
cop = (eer / OpenStudio.convert(1.0, 'W', 'Btu/h').get + r) / (1 - r) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use the |
||
else | ||
# The 90.1-2013 method | ||
# Convert the capacity to Btu/hr | ||
|
@@ -365,13 +365,13 @@ def eer_to_cop(eer, capacity_w = nil) | |
# | ||
# @param cop [Double] COP | ||
# @return [Double] Energy Efficiency Ratio (EER) | ||
def cop_to_eer(cop, capacity_w = nil) | ||
def cop_to_eer_no_fan(cop, capacity_w = nil) | ||
if capacity_w.nil? | ||
# The PNNL Method. | ||
# r is the ratio of supply fan power to total equipment power at the rating condition, | ||
# assumed to be 0.12 for the reference buildngs per PNNL. | ||
r = 0.12 | ||
eer = 3.413 * (cop * (1 - r) - r) | ||
eer = OpenStudio.convert(1.0, 'W', 'Btu/h').get * (cop * (1 - r) - r) | ||
else | ||
# The 90.1-2013 method | ||
# Convert the capacity to Btu/hr | ||
|
@@ -382,6 +382,14 @@ def cop_to_eer(cop, capacity_w = nil) | |
return eer | ||
end | ||
|
||
# Convert from EER to COP | ||
# | ||
# @param cop [Double] Energy Efficiency Ratio (EER) | ||
# @return [Double] Coefficient of Performance (COP) | ||
def eer_to_cop(eer) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add new function to do a straight EER to COP conversion. |
||
return eer / OpenStudio.convert(1.0, 'W', 'Btu/h').get | ||
end | ||
|
||
# Convert from COP to kW/ton | ||
# | ||
# @param cop [Double] Coefficient of Performance (COP) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions were mislabeled. They did not correspond to a straight EER to COP conversion but rather excluded the effect of the fan when doing the conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khaddad, @ckirney - as per our discussion/email, see the changes in
lib/openstudio-standards/prototypes/common/objects/Prototype.utilities.rb
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks