-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appendix G test refactor #1689
Merged
Merged
Appendix G test refactor #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into AppendixG_Dev
…into AppendixG_Dev
update water use equipment for user data
update the wateruse equipment handler.
Reorganizing prm_test_helper
…into AppendixG_Dev
Appendix g dev merge master 12202023
…into AppendxiG_dev_fix_error_processing_schedule # Conflicts: # lib/openstudio-standards/standards/Standards.Model.rb # test/90_1_prm/prm_check.rb # test/90_1_prm/test_appendix_g_prm.rb
…b.com/NREL/openstudio-standards into AppendxiG_dev_fix_error_processing_schedule
…into AppendixG_Dev # Conflicts: # lib/openstudio-standards/standards/Standards.Model.rb # test/90_1_prm/prm_check.rb # test/90_1_prm/test_appendix_g_prm.rb
…into AppendxiG_dev_fix_error_processing_schedule
…andards into AppendxiG_dev_fix_error_processing_schedule # Conflicts: # test/90_1_prm/test_appendix_g_prm.rb
test_fan_power_credits test_envelope
test_hvac_psz_split_from_mz test_pe_userdata_handling
test_hvac_sizing_02
…_schedule Appendxi g dev fix error processing schedule
…into AppendixG_Dev
mdahlhausen
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I breakdown top listed test cases into smaller set test cases in hope that the parallelism can speed up the overall CI process. I have no visibility on the time run for each test case. Please do let us know if we need to further reduce the time.
Pull request overview
Pull Request Author
bundle exec rake doc
)bundle exec rake rubocop
)require
statements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.