Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appendix G test refactor #1689

Merged
merged 37 commits into from
Feb 23, 2024
Merged

Appendix G test refactor #1689

merged 37 commits into from
Feb 23, 2024

Conversation

weilixu
Copy link
Collaborator

@weilixu weilixu commented Feb 19, 2024

I breakdown top listed test cases into smaller set test cases in hope that the parallelism can speed up the overall CI process. I have no visibility on the time run for each test case. Please do let us know if we need to further reduce the time.

Pull request overview

  1. Breakdown test files into multiple files,
  2. Temporarily remove test cases that has error warmup convergence messages (which causes simulation long),
  3. Breakdown multiple unit tests into smaller set unit tests
  4. Add PRM user data processing module
  5. Add support for more types of user data.
  6. Refactor schedule functions using the new schedule module.

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

weilixu and others added 30 commits October 11, 2023 08:50
…into AppendxiG_dev_fix_error_processing_schedule

# Conflicts:
#	lib/openstudio-standards/standards/Standards.Model.rb
#	test/90_1_prm/prm_check.rb
#	test/90_1_prm/test_appendix_g_prm.rb
…into AppendixG_Dev

# Conflicts:
#	lib/openstudio-standards/standards/Standards.Model.rb
#	test/90_1_prm/prm_check.rb
#	test/90_1_prm/test_appendix_g_prm.rb
…into AppendxiG_dev_fix_error_processing_schedule
…andards into AppendxiG_dev_fix_error_processing_schedule

# Conflicts:
#	test/90_1_prm/test_appendix_g_prm.rb
test_fan_power_credits
test_envelope
test_hvac_psz_split_from_mz
test_pe_userdata_handling
test_hvac_sizing_02
…_schedule

Appendxi g dev fix error processing schedule
@weilixu weilixu requested a review from mdahlhausen February 19, 2024 15:22
@weilixu weilixu marked this pull request as ready for review February 20, 2024 18:58
@mdahlhausen mdahlhausen merged commit b013cc8 into master Feb 23, 2024
@lymereJ lymereJ mentioned this pull request Apr 4, 2024
15 tasks
@mdahlhausen mdahlhausen changed the title Appendix g dev Appendix G test refactor Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants