Humble #6
Open
Humble #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix spawner tests timeout (#1692) (cherry picked from commit 079392b) # Conflicts: # controller_manager/test/test_spawner_unspawner.cpp * Fix merge conflicts --------- Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
…#1661) (#1695) * Refactor spawner to be able to reuse code for ros2controlcli (#1661) (cherry picked from commit 0631e3e) # Conflicts: # controller_manager/controller_manager/spawner.py # controller_manager/test/test_spawner_unspawner.cpp * [Humble] Fix conflicts of 1661 backport (#1735) * Fix conflicts * added controller_type parameter setting to the spawner --------- Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
…robot_description through topic (backport #1451) (#1599) * Add resources_lock_ lock_guards to avoid race condition when loading robot_description through topic (#1451) (cherry picked from commit 25f2c97) # Conflicts: # hardware_interface/src/resource_manager.cpp * Try fixing conflict. --------- Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> Co-authored-by: Dr. Denis <denis@stoglrobotics.de> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
* Fix timeout value in std output (#1807) We were using the wrong timeout in the terminal output there. (cherry picked from commit cb91599) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py * Update controller_manager_services.py --------- Co-authored-by: Felix Exner (fexner) <exner@fzi.de> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
* Add few warning compiler options to error (#1181) * add conversion, unused-but-set-variable, and return-type warnings to error * add shadow variables to error and their fixes for code compilation * apply the same flags to controller interface package * apply the same flags and their fixes to hardware_interface package * apply the same compiler options to the rest of the packages * Deactivate compiler warning for class_loader --------- Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
#1842) Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.