Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions Workflow job to run NVTabular unit tests on GPU #288

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oliverholworthy
Copy link
Member

Add GitHub Actions Workflow job to run NVTabular unit tests on GPU.

Motivation: To help us catch issues with GPU device functionality in NVTabular that relies on 'core' before a PR is merged

@oliverholworthy oliverholworthy added this to the Merlin 23.04 milestone Apr 17, 2023
@oliverholworthy oliverholworthy self-assigned this Apr 17, 2023
@karlhigley
Copy link
Contributor

Historically we ran them on CPU only in order to avoid creating logjams on the GPU resources when the tests run in Core. This might be a reasonable and/or necessary thing to do, but we should tread carefully given the time it takes to run our test suites.

@karlhigley karlhigley modified the milestones: Merlin 23.04, Merlin 23.05 Apr 25, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

Documentation preview

https://nvidia-merlin.github.io/core/review/pr-288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants