Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions Workflow job to run NVTabular unit tests on GPU #288

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/merlin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,10 @@ jobs:
name: "NVTabular (CPU)"
uses: ./.github/workflows/tox.yml
with:
env: test-nvtabular-cpu
env: test-nvtabular

nvtabular-gpu:
name: "NVTabular (GPU)"
uses: ./.github/workflows/tox-gpu.yml
with:
env: test-nvtabular
26 changes: 26 additions & 0 deletions .github/workflows/tox-gpu.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: "Reusable Workflow - Run Tox Env (1GPU)"

on:
workflow_call:
inputs:
env:
description: "The name of the tox environment to run"
required: true
type: string

jobs:
check:
runs-on: 1GPU

steps:
- uses: actions/checkout@v3
- name: Run tests
run: |
ref_type=${{ github.ref_type }}
branch=main
if [[ $ref_type == "tag"* ]]
then
raw=$(git branch -r --contains ${{ github.ref_name }})
branch=${raw/origin\/}
fi
GIT_COMMIT=`git rev-parse HEAD` tox -e ${{ inputs.env }} -- $branch
9 changes: 7 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,13 @@ commands =
python -m pytest --cov-report term --cov merlin -rxs tests/unit


[testenv:test-nvtabular-cpu]
passenv=GIT_COMMIT
[testenv:test-nvtabular]
setenv =
TF_GPU_ALLOCATOR=cuda_malloc_async
passenv =
GIT_COMMIT
OPAL_PREFIX
CUDA_VISIBLE_DEVICES
sitepackages=true
allowlist_externals = git
deps =
Expand Down