[NeMo-UX] Rename weights path during resume (#10391) (#10516)

* rename weights path to avoid confusion



* use pathlib utils rather than os



* update resume_from_path and context_path



* address comment



---------

Signed-off-by: ashors1 <ashors@nvidia.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>

nemo/lightning/resume.py

@@ -84,7 +84,7 @@ class AutoResume:
 
     WEIGHTS_PATH = "weights"
 
-    def get_model_weights_path(self, path):
+    def get_weights_path(self, path):
         return Path(path) / self.WEIGHTS_PATH
 
     def setup(self, trainer: Union[pl.Trainer, fl.Fabric], model=None):
@@ -127,9 +127,9 @@ def _try_import_model(
 
         if adapter_path:
 
-            maybe_model_weights_path = self.get_model_weights_path(adapter_path)
-            if os.path.isdir(maybe_model_weights_path):
-                adapter_path = maybe_model_weights_path
+            maybe_weights_path = self.get_weights_path(adapter_path)
+            if maybe_weights_path.is_dir():
+                adapter_path = maybe_weights_path
 
             new_path = AdapterPath(Path(adapter_path), base_model_path=new_path)
 
@@ -244,15 +244,15 @@ def get_context_path(self, model: Optional[io.ConnectorMixin] = None) -> Optiona
             checkpoint = self._find_trainer_ckpt_path()
 
         if checkpoint:
-            maybe_model_weights_path = Path(checkpoint) / "context"
-            if os.path.isdir(maybe_model_weights_path):
-                checkpoint = maybe_model_weights_path
+            maybe_context_path = Path(checkpoint) / "context"
+            if maybe_context_path.is_dir():
+                checkpoint = maybe_context_path
         return checkpoint
 
     def get_trainer_ckpt_path(self, model: Optional[io.ConnectorMixin] = None) -> Optional[Path]:
         if self.resume_from_path:
-            maybe_model_weights_path = self.get_model_weights_path(self.resume_from_path)
-            return maybe_model_weights_path if os.path.isdir(maybe_model_weights_path) else self.resume_from_path
+            maybe_weights_path = self.get_weights_path(self.resume_from_path)
+            return maybe_weights_path if maybe_weights_path.is_dir() else self.resume_from_path
 
         checkpoint = None
         app_state = AppState()
@@ -261,9 +261,9 @@ def get_trainer_ckpt_path(self, model: Optional[io.ConnectorMixin] = None) -> Op
             checkpoint = self._find_trainer_ckpt_path()
 
         if checkpoint:
-            maybe_model_weights_path = self.get_model_weights_path(checkpoint)
-            if os.path.isdir(maybe_model_weights_path):
-                checkpoint = maybe_model_weights_path
+            maybe_weights_path = self.get_weights_path(checkpoint)
+            if maybe_weights_path.is_dir():
+                checkpoint = maybe_weights_path
 
         if checkpoint:
             if self.adapter_path: