[NeMo-UX] Rename weights path during resume #10391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
cuichenx
reviewed
Sep 10, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
ko3n1g
pushed a commit
that referenced
this pull request
Sep 15, 2024
* rename weights path to avoid confusion Signed-off-by: ashors1 <ashors@nvidia.com> * use pathlib utils rather than os Signed-off-by: ashors1 <ashors@nvidia.com> * update resume_from_path and context_path Signed-off-by: ashors1 <ashors@nvidia.com> * address comment Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
* rename weights path to avoid confusion Signed-off-by: ashors1 <ashors@nvidia.com> * use pathlib utils rather than os Signed-off-by: ashors1 <ashors@nvidia.com> * update resume_from_path and context_path Signed-off-by: ashors1 <ashors@nvidia.com> * address comment Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: adityavavre <aditya.vavre@gmail.com>
ashors1
added a commit
that referenced
this pull request
Sep 17, 2024
* rename weights path to avoid confusion Signed-off-by: ashors1 <ashors@nvidia.com> * use pathlib utils rather than os Signed-off-by: ashors1 <ashors@nvidia.com> * update resume_from_path and context_path Signed-off-by: ashors1 <ashors@nvidia.com> * address comment Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
ashors1
added a commit
that referenced
this pull request
Sep 25, 2024
* rename weights path to avoid confusion * use pathlib utils rather than os * update resume_from_path and context_path * address comment --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
ko3n1g
added a commit
that referenced
this pull request
Sep 26, 2024
* rename weights path to avoid confusion * use pathlib utils rather than os * update resume_from_path and context_path * address comment --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
maanug-nv
pushed a commit
that referenced
this pull request
Oct 2, 2024
* rename weights path to avoid confusion Signed-off-by: ashors1 <ashors@nvidia.com> * use pathlib utils rather than os Signed-off-by: ashors1 <ashors@nvidia.com> * update resume_from_path and context_path Signed-off-by: ashors1 <ashors@nvidia.com> * address comment Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* rename weights path to avoid confusion Signed-off-by: ashors1 <ashors@nvidia.com> * use pathlib utils rather than os Signed-off-by: ashors1 <ashors@nvidia.com> * update resume_from_path and context_path Signed-off-by: ashors1 <ashors@nvidia.com> * address comment Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* rename weights path to avoid confusion Signed-off-by: ashors1 <ashors@nvidia.com> * use pathlib utils rather than os Signed-off-by: ashors1 <ashors@nvidia.com> * update resume_from_path and context_path Signed-off-by: ashors1 <ashors@nvidia.com> * address comment Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* rename weights path to avoid confusion Signed-off-by: ashors1 <ashors@nvidia.com> * use pathlib utils rather than os Signed-off-by: ashors1 <ashors@nvidia.com> * update resume_from_path and context_path Signed-off-by: ashors1 <ashors@nvidia.com> * address comment Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* rename weights path to avoid confusion Signed-off-by: ashors1 <ashors@nvidia.com> * use pathlib utils rather than os Signed-off-by: ashors1 <ashors@nvidia.com> * update resume_from_path and context_path Signed-off-by: ashors1 <ashors@nvidia.com> * address comment Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Minor improvements to
AutoResumeclass to improve readabilityCollection: llm
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information