-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding security context to initContainer #756
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kndoni please also add this to the other daemonsest in the helm package.
deployments/helm/nvidia-device-plugin/templates/daemonset-device-plugin.yml
Show resolved
Hide resolved
I have added security context for other containers in daemonsets as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that adding a security context if we're already running a container as priveleved makes sense. We also do not have the template used for the mps-control-daemon defined.
deployments/helm/nvidia-device-plugin/templates/daemonset-mps-control-daemon.yml
Outdated
Show resolved
Hide resolved
deployments/helm/nvidia-device-plugin/templates/daemonset-mps-control-daemon.yml
Outdated
Show resolved
Hide resolved
@elezar Let me know if something else should be changed as well. |
6e27784
to
a2328f0
Compare
Adding security context to init container as keyverno policies implies that initContainer should have securityContext defined as well Signed-off-by: Kristi <74095043+kndoni@users.noreply.github.com>
Signed-off-by: Kristi <74095043+kndoni@users.noreply.github.com>
Signed-off-by: Kristi <74095043+kndoni@users.noreply.github.com>
Signed-off-by: Kristi <74095043+kndoni@users.noreply.github.com>
Signed-off-by: Kristi <74095043+kndoni@users.noreply.github.com>
Signed-off-by: Kristi <74095043+kndoni@users.noreply.github.com>
…s daemonset Signed-off-by: Kristi <74095043+kndoni@users.noreply.github.com>
Changes