-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding security context to initContainer #756
Open
kndoni
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
kndoni:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7929490
Adding security context to initContainer
kndoni 5437936
Adding security contexts for all containers in deamonset gdf and mps
kndoni 521f122
Removed security context from privileged container
kndoni 213ae30
Adding securityContexts for all containers and initContainers
kndoni 640c8ca
Adding capabilities for MIG_MONITOR_DEVICES property
kndoni 3373636
Adding correct capabilities to container
kndoni 0cfce42
Adding property for specifically enabling or disabling devicePluginMp…
kndoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,6 +92,12 @@ spec: | |
mountPath: /available-configs | ||
- name: config | ||
mountPath: /config | ||
{{- with .Values.resources }} | ||
resources: | ||
{{- toYaml . | nindent 10 }} | ||
{{- end }} | ||
securityContext: | ||
kndoni marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{{- include "nvidia-device-plugin.securityContext" . | nindent 10 }} | ||
{{- end }} | ||
containers: | ||
{{- if $options.hasConfigMap }} | ||
|
@@ -128,6 +134,10 @@ spec: | |
mountPath: /available-configs | ||
- name: config | ||
mountPath: /config | ||
{{- with .Values.resources }} | ||
resources: | ||
{{- toYaml . | nindent 10 }} | ||
{{- end }} | ||
securityContext: | ||
{{- include "nvidia-device-plugin.securityContext" . | nindent 10 }} | ||
{{- end }} | ||
|
@@ -184,6 +194,9 @@ spec: | |
value: compute,utility | ||
securityContext: | ||
{{- include "nvidia-device-plugin.securityContext" . | nindent 10 }} | ||
capabilities: | ||
add: | ||
- SYS_ADMIN | ||
Comment on lines
+197
to
+199
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was this added? There was an issue #856 which should be resolved in the latest release. |
||
volumeMounts: | ||
- name: device-plugin | ||
mountPath: /var/lib/kubelet/device-plugins | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,6 +92,12 @@ spec: | |
mountPath: /available-configs | ||
- name: config | ||
mountPath: /config | ||
{{- with .Values.resources }} | ||
resources: | ||
{{- toYaml . | nindent 10 }} | ||
{{- end }} | ||
securityContext: | ||
{{- include "nvidia-device-plugin.securityContext" . | nindent 10 }} | ||
{{- end }} | ||
containers: | ||
{{- if $options.hasConfigMap }} | ||
|
@@ -128,8 +134,12 @@ spec: | |
mountPath: /available-configs | ||
- name: config | ||
mountPath: /config | ||
{{- with .Values.resources }} | ||
resources: | ||
{{- toYaml . | nindent 10 }} | ||
{{- end }} | ||
securityContext: | ||
{{- include "gpu-feature-discovery.securityContext" . | nindent 10 }} | ||
{{- include "nvidia-device-plugin.securityContext" . | nindent 10 }} | ||
{{- end }} | ||
- image: {{ include "nvidia-device-plugin.fullimage" . }} | ||
imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
|
@@ -175,7 +185,10 @@ spec: | |
- name: GFD_MODE | ||
value: "{{ .Values.gfdMode }}" | ||
securityContext: | ||
{{- include "gpu-feature-discovery.securityContext" . | nindent 10 }} | ||
{{- include "nvidia-device-plugin.securityContext" . | nindent 10 }} | ||
capabilities: | ||
add: | ||
- SYS_ADMIN | ||
Comment on lines
+189
to
+191
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar question here. See #856 |
||
volumeMounts: | ||
- name: output-dir | ||
mountPath: "/etc/kubernetes/node-feature-discovery/features.d" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general question: Does it make sense to apply the same resources to each of the containers?