Enable some integration tests for from_json
#11805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
revans2
reviewed
Dec 2, 2024
| @@ -1396,7 +1395,6 @@ def test_spark_from_json_empty_table(data): | |||
| conf =_enable_all_types_conf) | |||
|
|
|||
| # SPARK-20549: from_json bad UTF-8 | |||
| @pytest.mark.xfail(reason='https://github.com/NVIDIA/spark-rapids/issues/10483') | |||
There was a problem hiding this comment.
I am a little confused here. #10483 is closed. I am guessing that I messed enabling this test again some how, but I thought I had gone through all of them. Oh well. So what is the issue that is blocking this from working properly? Or is it just that I forgot to mark it as working?
There was a problem hiding this comment.
I verified with the latest code that the issue #10483 is fixed thus I think this is just forgotten from being changed in your last PR.
|
build |
revans2
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns on some tests that are fixed.
Depends on: