Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some integration tests for from_json #11805

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Enable some integration tests for from_json #11805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions integration_tests/src/main/python/json_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,6 @@ def test_from_json_struct_of_list_with_mismatched_schema():
'struct<student:array<struct<name:string,class:string>>>',
'struct<teacher:string,student:array<struct<name:string,class:string>>>'])
@allow_non_gpu(*non_utc_allow)
@pytest.mark.xfail(reason='https://github.com/rapidsai/cudf/issues/17349')
def test_from_json_struct_of_list_with_mixed_nested_types_input(schema):
json_string_gen = StringGen(r'{"teacher": "[A-Z]{1}[a-z]{2,5}",' \
r'"student": \[{"name": "[A-Z]{1}[a-z]{2,5}", "class": "junior"},' \
Expand Down Expand Up @@ -1396,7 +1395,6 @@ def test_spark_from_json_empty_table(data):
conf =_enable_all_types_conf)

# SPARK-20549: from_json bad UTF-8
@pytest.mark.xfail(reason='https://github.com/NVIDIA/spark-rapids/issues/10483')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused here. #10483 is closed. I am guessing that I messed enabling this test again some how, but I thought I had gone through all of them. Oh well. So what is the issue that is blocking this from working properly? Or is it just that I forgot to mark it as working?

Copy link
Collaborator Author

@ttnghia ttnghia Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified with the latest code that the issue #10483 is fixed thus I think this is just forgotten from being changed in your last PR.

@allow_non_gpu(*non_utc_allow) # https://github.com/NVIDIA/spark-rapids/issues/10453
def test_spark_from_json_bad_json():
schema = StructType([StructField("a", IntegerType())])
Expand Down
Loading