Enable build and test with JDK11 #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
|
build |
|
build |
otherwise activateByDefault is not activated
|
build |
Signed-off-by: Gera Shegalov <gera@apache.org>
jlowe
reviewed
May 19, 2022
Closes NVIDIA#5557 Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
changed the title
Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
jlowe
reviewed
May 20, 2022
Comment on lines
+115
to
+117
| Also make sure to use scala-maven-plugin version `scala.plugin.version` 4.6.0 or later to correctly process | ||
| [maven.compiler.release](https://github.com/davidB/scala-maven-plugin/blob/4.6.1/src/main/java/scala_maven/ScalaMojoSupport.java#L161) | ||
| flag if cross-compilation is required. |
There was a problem hiding this comment.
Curious why we don't simply update the scala plugin version in the pom? Is there something that breaks if we do?
There was a problem hiding this comment.
nothing should break, however, I am mitigating risks since my time for this effort is limited and cross-compilation is not necessary right now.
There was a problem hiding this comment.
Seems like we should do a followup for this then? Normally we don't tolerate bugs long-term in Maven plugins if upgrading to a fixed version works.
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
jlowe
approved these changes
May 20, 2022
|
build |
1 similar comment
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #4649, #3682.
allowConventionalDistJarfor conventional jar creation when only one shim is includedmaven .compiler.*and adds the right set of javac opts automatically. 3.4.x we use for db doesn't handle maven.compiler.release, however, we don't need it at the moment and it's currently not used.Note this PR only builds skipping running tests
-DskipTestsbecause we still need to address #3851 (comment)Signed-off-by: Gera Shegalov gera@apache.org