Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1262
Fixes three issues currently found in the
_get_dft_array
routine.dim
. 2D simulations don't set the third dimension by default, consequently whatever garbage is in memory becomes the third dimension. This is obviously problematic when creating a python array from the dimension object.0
. This is especially important for adjoint calculations, which need to store all field components and don't have knowledge about which components meep is actually calculating. The current adjoint toolbox will already broadcast the0
accordingly.PyArray_SimpleNewFromData
to create and copy the array data.