Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two memory leaks in geom_epsilon class #1877

Merged
merged 3 commits into from
Jan 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/meepgeom.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ void set_default_material(material_type _default_material) {
}
}

void unset_default_material(void) {
if (default_material != NULL) {
material_free((material_type)default_material);
default_material = NULL;
}
}

bool susceptibility_equal(const susceptibility &s1, const susceptibility &s2) {
return (vector3_equal(s1.sigma_diag, s2.sigma_diag) &&
vector3_equal(s1.sigma_offdiag, s2.sigma_offdiag) && vector3_equal(s1.bias, s2.bias) &&
Expand Down Expand Up @@ -761,7 +768,8 @@ void geom_epsilon::set_volume(const meep::volume &v) {
unset_volume();

geom_box box = gv2box(v);
restricted_tree = create_geom_box_tree0(geometry, box);
if (!restricted_tree)
restricted_tree = create_geom_box_tree0(geometry, box);
}

static void material_epsmu(meep::field_type ft, material_type material, symm_matrix *epsmu,
Expand Down Expand Up @@ -1918,8 +1926,8 @@ void add_absorbing_layer(absorber_list alist, double thickness, int direction, i
/* create a geom_epsilon object that can persist
if needed */
geom_epsilon* make_geom_epsilon(meep::structure *s, geometric_object_list *g, vector3 center,
bool _ensure_periodicity, material_type _default_material,
material_type_list extra_materials) {
bool _ensure_periodicity, material_type _default_material,
material_type_list extra_materials) {
// set global variables in libctlgeom based on data fields in s
geom_initialize();
geometry_center = center;
Expand Down Expand Up @@ -1980,17 +1988,17 @@ void set_materials_from_geometry(meep::structure *s, geometric_object_list g, ve
bool _ensure_periodicity, material_type _default_material,
absorber_list alist, material_type_list extra_materials) {
meep_geom::geom_epsilon *geps = meep_geom::make_geom_epsilon(s, &g, center, _ensure_periodicity,
_default_material, extra_materials);
_default_material, extra_materials);
set_materials_from_geom_epsilon(s, geps, use_anisotropic_averaging, tol,
maxeval, alist);
maxeval, alist);
delete geps;
}

/* from a previously created geom_epsilon object,
set the materials as specified */
void set_materials_from_geom_epsilon(meep::structure *s, geom_epsilon *geps,
bool use_anisotropic_averaging,
double tol, int maxeval, absorber_list alist) {
bool use_anisotropic_averaging,
double tol, int maxeval, absorber_list alist) {

// store for later use in gradient calculations
geps->tol = tol;
Expand All @@ -2007,7 +2015,7 @@ void set_materials_from_geom_epsilon(meep::structure *s, geom_epsilon *geps,
mythunk.func = layer->pml_profile;
mythunk.func_data = layer->pml_profile_data;
geps->set_cond_profile(d, b, layer->thickness, gv.inva * 0.5, pml_profile_wrapper,
(void *)&mythunk, layer->R_asymptotic);
(void *)&mythunk, layer->R_asymptotic);
}
}
}
Expand Down
1 change: 1 addition & 0 deletions src/meepgeom.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ vector3 vec_to_vector3(const meep::vec &pt);
meep::vec vector3_to_vec(const vector3 v3);

void set_default_material(material_type _default_material);
void unset_default_material(void);
void epsilon_material_grid(material_data *md, double u);
void epsilon_file_material(material_data *md, vector3 p);
bool susceptibility_equal(const susceptibility &s1, const susceptibility &s2);
Expand Down
1 change: 1 addition & 0 deletions tests/array-slice-ll.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ int main(int argc, char *argv[]) {
for (int n = 0; n < no; n++) {
geometric_object_destroy(objects[n]);
}
meep_geom::unset_default_material();

return 0;
}
1 change: 1 addition & 0 deletions tests/cyl-ellipsoid-ll.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ int main(int argc, char *argv[]) {
for (int n = 0; n < 2; n++) {
geometric_object_destroy(objects[n]);
}
meep_geom::unset_default_material();

return 0;
}