Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for load_minus_flux to objective functions of adjoint solver #2271

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Oct 15, 2022

Fixes #2266.

Adds a new class member norm_dft_fields to the EigenmodeCoefficient and FourierFields objective functions (and member norm_near_fields to class Near2FarFields) of the adjoint solver. Also includes a unit test.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #2271 (af1fb53) into master (49aef42) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master    #2271   +/-   ##
=======================================
  Coverage   73.24%   73.25%           
=======================================
  Files          17       17           
  Lines        4919     4928    +9     
=======================================
+ Hits         3603     3610    +7     
- Misses       1316     1318    +2     
Impacted Files Coverage Δ
python/adjoint/objective.py 92.38% <80.00%> (-0.66%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding support for load_minus_flux to EigenmodeCoefficient objective function of adjoint solver
4 participants