fix dB calculation in Meep scripts for waveguide mode converter and other improvements #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the computation of the reflectance and transmittance spectrum in dB units in the Meep scripts for the waveguide mode converter. To convert$R=|S_{11}|^2$ to dB involves $10\log_{10}{R}$ rather than $20\log_{10}{R}$ which meant that the previously reported values were twice the actual values. The plots below show the corrected spectrum for the topology-optimized designs. The values are now comparable with those reported in Schubert et al., (2022).
The topology optimization script is also updated to use
subtracted_dft_fields(rather thannorm_dft_fields) introduced by NanoComp/meep#2271 after #25 was merged.