Increase initial number of grid points used in phi quadrature for near-to-far field transformation in cylindrical coordinates #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-to-far field transformation in cylindrical coordinates
|
128 might be a little on the large side for e.g. Probably it should increase proportional to Would e.g. |
Verified that this produces nearly the same results in #2726 (comment) as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2764.
Rather than make the number of grid points in the$\phi$ quadrature a user parameter in
get_farfields, it is simpler just to increase the hard-coded value forN0set internally ingreencyl. The impact of integrating over a larger number of grid points should be insignificant when compared to the accuracy improvements enabled by this modification as this integral converges exponentially fast.