Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbosity improvements #125

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

RobinD42
Copy link
Contributor

@RobinD42 RobinD42 commented Oct 6, 2020

Switch most mpb_verbosity checks to be >=1, and change the linmin messages to >=2

See NanoComp/meep#1362 and NanoComp/meep#1388

@stevengj stevengj merged commit 02a28f8 into NanoComp:master Oct 6, 2020
@RobinD42 RobinD42 deleted the verbosity-improvements branch October 6, 2020 19:23
@thchr
Copy link
Contributor

thchr commented Oct 18, 2020

This seems to have the same problem that I brought up in #119 (comment) and fixed in #123?

Specifically, if the default verbosity level for MPB is 2, then this prints the linmin messages by default - which is a lot of extra stuff. That seems to be the current situation, cf. Travis reports for this PR.

I'm guessing this works well with Meep, if it's reducing the verbosity level by 1 when calling out to MPB; but it's not too nice for working with MPB on its own.

@thchr
Copy link
Contributor

thchr commented Nov 5, 2020

@RobinD42: another consequence of this issue is that e.g. the Meep logs now exceed the allowable length on Travis due to repeated prints of "linmin: converged after ...", see e.g. https://travis-ci.org/github/NanoComp/meep/jobs/741695728#L79272

Wouldn't it better to roll back these changes to linmin printing?

@stevengj
Copy link
Collaborator

stevengj commented Nov 6, 2020

Wouldn't it better to roll back these changes to linmin printing?

Yes, we can do that; it may have been an inadvertent change. Can you make a PR?

@thchr
Copy link
Contributor

thchr commented Nov 6, 2020

Sure (I probably won't get around to it until the second half of next week though)!

@stevengj
Copy link
Collaborator

stevengj commented Nov 15, 2020

@thchr, we changed the MPB default verbosity to 1 in #130, which should fix this. (It was already 1 in the Python interface.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants