Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default verbosity to 1 #130

Merged
merged 1 commit into from
Nov 15, 2020
Merged

change default verbosity to 1 #130

merged 1 commit into from
Nov 15, 2020

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Nov 12, 2020

This is a resolution to @tchr's comment in #125 proposed by @RobinD42:

As for the verbosity issue, a super simple change that should keep both Steven and Thomas happy would be to change the mpb_verbosity variable's default value to 1 in mpb's src/util/verbosity.c. Then it will start out as 1 when mpb is used on its own as Thomas seems to be doing, but it will still be set to 2 when it is loaded into the Python Verbosity class from meep, which IIRC is what Steven wanted.

@stevengj
Copy link
Collaborator

Should also default to 1 under pymeep.

@stevengj stevengj merged commit f9da8c7 into NanoComp:master Nov 15, 2020
@oskooi oskooi deleted the verbosity_default_one branch November 15, 2020 01:36
@oskooi
Copy link
Collaborator Author

oskooi commented Nov 15, 2020

Seems the MPB verbosity under PyMeep is already 1 by default:

https://github.com/NanoComp/meep/blob/ad8d8088ea82375ca9c24d9034a1fa5b6c54b201/python/mpb.i#L359-L360

@stevengj stevengj mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskooi @stevengj