Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize command is really slow #236

Closed
osma opened this issue Jan 18, 2019 · 3 comments
Closed

Optimize command is really slow #236

osma opened this issue Jan 18, 2019 · 3 comments
Labels
Milestone

Comments

@osma
Copy link
Member

osma commented Jan 18, 2019

There is something wrong with the optimize command. It used to be fast, but now it can take several minutes just to produce the table of results. I suspect this has to do with converting analysis results from lists to vectors (or vice versa) when evaluating different limit and threshold settings.

@osma osma added the bug label Jan 18, 2019
@osma osma added this to the v0.39 milestone Jan 18, 2019
@osma
Copy link
Member Author

osma commented Jan 18, 2019

It also seems to take a lot of memory - 4GB even for Maui projects where there should be no need to load models etc.

@osma
Copy link
Member Author

osma commented Jan 18, 2019

Main issue seems to be that running all the evaluation measures just takes a lot of processing. The easiest fix would be to disable the nonessential eval measures (e.g. Prec@1, LRAP, true positives...) when running in optimize mode, as they are not really needed for the optimize command.

@osma
Copy link
Member Author

osma commented Jan 24, 2019

High memory usage is still a problem with the optimize command. The intermediate AnalysisResults are not being freed, so memory usage grows during execution and can reach several GB after all parameter combinations have been tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant