Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up optimize command and avoid high memory usage #238

Merged
merged 6 commits into from
Jan 21, 2019

Conversation

osma
Copy link
Member

@osma osma commented Jan 21, 2019

Fixes #236

@osma osma added the bug label Jan 21, 2019
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #238 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   98.58%   98.62%   +0.03%     
==========================================
  Files          48       48              
  Lines        2121     2178      +57     
==========================================
+ Hits         2091     2148      +57     
  Misses         30       30
Impacted Files Coverage Δ
annif/hit.py 95.32% <100%> (+1.2%) ⬆️
annif/cli.py 96.98% <100%> (ø) ⬆️
annif/eval.py 100% <100%> (ø) ⬆️
tests/test_hit.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299d844...606215b. Read the comment docs.

@osma osma merged commit ccff81a into master Jan 21, 2019
@osma osma deleted the issue236-slow-optimize branch January 21, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant