Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation of LSI backend, with tests. Fixes #201 #219

Closed
wants to merge 1 commit into from

Conversation

osma
Copy link
Member

@osma osma commented Nov 28, 2018

Implementation of #201

@osma osma added this to the v0.38 milestone Nov 28, 2018
@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #219 into master will decrease coverage by 0.05%.
The diff coverage is 97.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #219      +/-   ##
=========================================
- Coverage   98.65%   98.6%   -0.06%     
=========================================
  Files          46      48       +2     
  Lines        2084    2148      +64     
=========================================
+ Hits         2056    2118      +62     
- Misses         28      30       +2
Impacted Files Coverage Δ
tests/test_backend_tfidf.py 100% <100%> (ø) ⬆️
annif/backend/__init__.py 100% <100%> (ø) ⬆️
tests/test_backend_lsi.py 100% <100%> (ø)
tests/conftest.py 100% <100%> (ø) ⬆️
annif/backend/lsi.py 95.74% <95.74%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0059fe8...9d2e7cf. Read the comment docs.

@osma osma mentioned this pull request Dec 14, 2018
@osma
Copy link
Member Author

osma commented Dec 14, 2018

Closing this PR for now, see #201 for evaluation results.

@osma osma closed this Dec 14, 2018
@osma osma modified the milestones: v0.38, Blue Sky Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant