-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations to tfidf backend training #335
Conversation
reasons I don't quite understand this brings a small performance boost
…ckend needs it and it is unlikely other backends will need it in the future
…te fit and transform steps
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
- Coverage 99.55% 99.52% -0.03%
==========================================
Files 56 56
Lines 3150 3166 +16
==========================================
+ Hits 3136 3151 +15
- Misses 14 15 +1
Continue to review full report at Codecov.
|
There are some complaints from the QA tools about the |
This pull request introduces 1 alert when merging 0c6ee3b into 244db95 - view on LGTM.com new alerts:
|
This PR contains several different optimizations meant to speed up training of tfidf models, which are currently quite slow to train:
Overall these changes speed up the training of tfidf projects by at least 2x, perhaps more in some cases.
I have some ideas on how to further improve performance of the tfidf backend, but I'll leave those for another PR.