-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yarn): yarn support for workspaces #4668
feat(yarn): yarn support for workspaces #4668
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Esteban Sánchez.
|
PR for this #4667 |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Esteban Sánchez.
|
Seems like I need a git course. I tried amending the commit, but it resulted in a brand new commit, and I still cant get the old commit verifed.. should I delete this PR? or is there a way to fix it. Thank you and sorry for the noise |
test cli-smoke |
@cla-bot check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Esteban Sánchez.
|
The cla-bot has been summoned, and re-checked this pull request! |
test cli-plugin cli-templates cli-preview |
@@ -228,7 +228,10 @@ export class PluginsService implements IPluginsService { | |||
} | |||
|
|||
private getPackageJsonFilePathForModule(moduleName: string, projectDir: string): string { | |||
return path.join(this.getNodeModulesPath(projectDir), moduleName, "package.json"); | |||
const pathToJsonFile = require.resolve(`${moduleName}/package.json`, { | |||
paths: [projectDir] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this code will work with Node.js 8.9 or later.
@easadev thanks a lot for your contribution. We'll run some tests and merge your PR. Meanwhile, it looks like one of your commits is with incorrect username, can you please squash all commits and push-force the branch, so we can ensure the CLA is signed. |
cfaf494
to
019a051
Compare
Hi, @rosen-vladimirov Thank you for reviewing this so quickly. I just squashed the commits and force pushed them as you suggested. |
test cli-plugin cli-templates cli-preview |
Hi @rosen-vladimirov I noticed that one check failed (ci/jenkins/nativescript-cli) but I cant see the details. Can I know what it was so that I can fix it? Thank you |
test cli-plugin |
Hey @easadev , |
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].