Remove .tnsproject and introduce package.json #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
1 similar comment
|
✅ |
| @@ -64,7 +64,7 @@ class ProjectIntegrationTest { | |||
| var projectDir = path.join(tempFolder, projectName); | |||
| var appDirectoryPath = path.join(projectDir, "app"); | |||
| var platformsDirectoryPath = path.join(projectDir, "platforms"); | |||
| var tnsProjectFilePath = path.join(projectDir, ".tnsproject"); | |||
| var tnsProjectFilePath = path.join(projectDir, "package.json"); | |||
There was a problem hiding this comment.
you can use let instead of var. Also I think the name of the variable should be changed to projectFilePath or packageJson for example.
|
👍 |
|
✅ |
|
|
||
| if (this.$fs.exists(this.projectFilePath).wait()) { | ||
| try { | ||
| var fileContent = this.$fs.readJson(this.projectFilePath).wait(); | ||
| this.projectId = fileContent.id; | ||
| var data = fileContent[this.$staticConfig.CLIENT_NAME_KEY_IN_PROJECT_FILE]; |
|
❌ |
Fatme
force-pushed
the
fatme/package.json
branch
3 times, most recently
from
6167dc3 to
9cf6f55
Compare
|
✅ |
|
✅ |
|
✅ |
Fatme
pushed a commit
that referenced
this pull request
May 19, 2015
Remove .tnsproject and introduce package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#362
Should be merged after this PR telerik/mobile-cli-lib#329