This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Check if project file is correct when looking for project dir #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private isProjectFileCorrect(projectFilePath: string): boolean { | ||
| if(this.$staticConfig.CLIENT_NAME_KEY_IN_PROJECT_FILE) { | ||
| var fileContent = this.$fs.readJson(projectFilePath).wait(); |
There was a problem hiding this comment.
This code can throw, should we catch it here and return false, or let uplevel code handle it?
There was a problem hiding this comment.
Actually when we use this function we are sure that the file exists - https://github.com/telerik/mobile-cli-lib/pull/329/files#diff-2fc55d29fa5bf8690e0a4ae30a71effdR25
There was a problem hiding this comment.
It exists, but the content may not be a JSON.
|
👍 |
Fatme
pushed a commit
that referenced
this pull request
May 19, 2015
Check if project file is correct when looking for project dir
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.