409 Conflict Response does not send the InstanceInfo back to the client #933
Comments
jebeaudet
added a commit
to jebeaudet/eureka
that referenced
this issue
Apr 21, 2017
When the server receive a heartbeat from a peer with a lastDirtyTimestamp lower than the timestamp it has, it will return a 409 Conflict response code. On the client side, it will use this status code to trigger a resync on this particular instance. The PeerReplicationResource was however stripping the required InstanceInfo from the response unless the status code was a 200 which is not the case here. This simple fix adds the InstanceInfo to the response in case of 409. Fixes Netflixgh-933
|
Sorry for the amended commits noise :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
InstanceResource, when renewing a lease andlastDirtyTimestampis not null, the code will return a 409 Conflict to the client in a certain situation. However,PeerReplicationResourcewill not return theInstanceInfoin the body of the response unless the status code is 200.On the client side of things,
PeerEurekaNodeneeds thisInstanceInfoto execute the methodsyncInstancesIfTimestampDiffers. Since it's never sent back from the server, this code never gets executed and you getThe replication of task XXX/i-XXX@XXX failed with response code 409logs until you fix it manually.PR submitted.
The text was updated successfully, but these errors were encountered: