Add the InstanceInfo to the response in case of 409 status code #934
Conversation
When the server receive a heartbeat from a peer with a lastDirtyTimestamp lower than the timestamp it has, it will return a 409 Conflict response code. On the client side, it will use this status code to trigger a resync on this particular instance. The PeerReplicationResource was however stripping the required InstanceInfo from the response unless the status code was a 200 which is not the case here. This simple fix adds the InstanceInfo to the response in case of 409. Fixes Netflixgh-933
|
Thanks @jebeaudet, taking a look ... |
|
@qiangdavidliu Have you had the chance to give it a look? We're releasing this patch in our production environment soon and I'd sleep better if I had your green thumbs on it 😉 |
|
Hi @jebeaudet apologies for the delayed response. This PR looks sound and makes logical sense, but I want to set up a quick test in our test env to test this out just to verify any potential unintended side effects. I'll let you know soon. |
|
@jebeaudet prelim trial seems ok, though there were some weirdness. Will merge this and I'll also set up a config guard for a quick 'undo'. Thanks for the contrib! |
|
@qiangdavidliu Did you get a chance to test it enough to remove the failguard of 6f3f997? |
|
@qiangdavidliu Any info about that safeguard? Thanks! |
Fixes #933.
Thanks!