too many queries to metadata url?

[aspyker]

https://github.com/Netflix/eureka/blob/master/eureka-client/src/main/java/com/netflix/appinfo/AmazonInfo.java#L118

autoBuild seems to have an algorithm that retries awsMetaDataRetries in case of error. I expected to see a break from the while (numOfRetries-- > 0) upon success (where it does result.metadata.put(key.getName(), value);). Instead in a version of this we copied and changed, we see it just try every query awsMetaDataRetries times.

We could submit a patch for this when we submit our similar class. However, I wanted to double check that I understood the code right and there is really a issue here.

[NiteshKant]

@aspyker it indeed is a bug. There should be a break after line 136. I will fix this.

[NiteshKant]

Available in release 1.1.128