You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
autoBuild seems to have an algorithm that retries awsMetaDataRetries in case of error. I expected to see a break from the while (numOfRetries-- > 0) upon success (where it does result.metadata.put(key.getName(), value);). Instead in a version of this we copied and changed, we see it just try every query awsMetaDataRetries times.
We could submit a patch for this when we submit our similar class. However, I wanted to double check that I understood the code right and there is really a issue here.
The text was updated successfully, but these errors were encountered:
1) Implementing clean shutdown of client. Moved away from Timer to ScheduledExecutorService as it gives better control of shutdown by interrupting the running thread, which is what we want.
2)
https://github.com/Netflix/eureka/blob/master/eureka-client/src/main/java/com/netflix/appinfo/AmazonInfo.java#L118
autoBuild seems to have an algorithm that retries awsMetaDataRetries in case of error. I expected to see a break from the while (numOfRetries-- > 0) upon success (where it does result.metadata.put(key.getName(), value);). Instead in a version of this we copied and changed, we see it just try every query awsMetaDataRetries times.
We could submit a patch for this when we submit our similar class. However, I wanted to double check that I understood the code right and there is really a issue here.
The text was updated successfully, but these errors were encountered: