Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client's clean shutdown #98

Closed
NiteshKant opened this issue Apr 15, 2014 · 1 comment
Closed

Client's clean shutdown #98

NiteshKant opened this issue Apr 15, 2014 · 1 comment
Assignees
@NiteshKant
Labels
bug

Comments

@NiteshKant
Copy link
Contributor

Eureka client on shutdown does not cancel all the scheduled tasks it has scheduled.
This may create a race-condition under which, the client may re-register with the server even after shutdown.

The race-condition lies in the Instance Info replication scheduled task which if there is a healthcheck handler registered with eureka, will re-register with the eureka server.

The fix is to cancel all the scheduled tasks at shutdown.
@NiteshKant NiteshKant self-assigned this Apr 15, 2014
@NiteshKant NiteshKant added the bug label Apr 15, 2014
NiteshKant pushed a commit to NiteshKant/eureka that referenced this issue Apr 15, 2014
Fixes issue Netflix#93 Netflix#97 Netflix#98 Netflix#99
ce1929b 
1) Implementing clean shutdown of client. Moved away from Timer to ScheduledExecutorService as it gives better control of shutdown by interrupting the running thread, which is what we want.
 2)
NiteshKant added a commit that referenced this issue Apr 15, 2014
@NiteshKant
Merge pull request #100 from NiteshKant/master
f0dec22 
Fixes issue #93 #97 #98 #99
@NiteshKant
Copy link
Contributor Author

Available in release 1.1.128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiteshKant NiteshKant

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NiteshKant