Handle submitted worker failure #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
calvin681,
sundargates,
hmitnflx and
fdc-ntflx
as code owners
Andyz26
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
Andyz26
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
markcho
approved these changes
Nov 14, 2024
james-lubin
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In some edge cases, where the node fails after accepting worker submission, the submitted request's handling failure is currently ignored, thus leaving the failed worker in a stuck state if the job is not fully launched yet (still in the initial batch scheduling state).
fix:
trigger scheduling failure to retry.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests