Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle submitted worker failure #726

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Handle submitted worker failure #726

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa15cdf
handle submitted failure
Andyz26 Nov 13, 2024
9f50786
Merge branch 'master' into andyz/fixFailureOnSumittedNode
Andyz26 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...src/main/java/io/mantisrx/server/master/scheduler/ResourceClusterAwareSchedulerActor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ private void onSubmittedScheduleRequestEvent(SubmittedScheduleRequestEvent event
try {
final TaskExecutorRegistration info = resourceCluster.getTaskExecutorInfo(taskExecutorID)
.join();
boolean success =
boolean success = //todo this return state is not wired to actual processing
jobMessageRouter.routeWorkerEvent(new WorkerLaunched(
event.getEvent().getRequest().getWorkerId(),
event.getEvent().getRequest().getStageNum(),
Expand All @@ -308,6 +308,7 @@ private void onSubmittedScheduleRequestEvent(SubmittedScheduleRequestEvent event
}
} catch (Exception ex) {
log.warn("Failed to route message due to error in getting TaskExecutor info: {}", taskExecutorID, ex);
self().tell(event.onFailure(ex), self());
}
}

Expand Down Expand Up @@ -520,6 +521,11 @@ private static class SubmittedScheduleRequestEvent {

ScheduleRequestEvent event;
TaskExecutorID taskExecutorID;

FailedToScheduleRequestEvent onFailure(Throwable throwable) {
return new FailedToScheduleRequestEvent(
this.event, 1, ExceptionUtils.stripCompletionException(throwable));
}
}

@Value
Expand Down
Loading