Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add i18n support&zh-cn Translation init. #133

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

cryptonerdcn
Copy link
Contributor

@cryptonerdcn cryptonerdcn commented Dec 1, 2023

Issue(s):

Description

Hi I am cryptonerd for Starknet Astro.
I added i18n support for StarknetByExample and init a zh-cn.po file for test, just like the CairoBook :P
It works perfectly for me. You can check it here: https://starknetastro.github.io/StarknetByExample/zh-cn/index.html

Checklist

  • CI Verifier: Run cairo_programs_verifier successfully
  • Contract Tests: Added tests to cover the changes
  • Remix Link: Added a link to open the contract in Remix
  • Deployed Contract (Optional): If possible, include a Voyager link to a deployed contract on Goerli

@cryptonerdcn
Copy link
Contributor Author

@julio4 @enitrat Can you review this PR? Thanks!

@cryptonerdcn
Copy link
Contributor Author

And of course my friends: @Nadai2010 @libdefi
Now it is your turn :)

@Nadai2010
Copy link
Contributor

Hello friends, at the end of next week I start to feel more free and I'll get to it. Thank you

@julio4
Copy link
Contributor

julio4 commented Dec 2, 2023

@cryptonerdcn Thank you a lot, this looks good to me.
I'm unable to review and maintain any additional translations. Are you available to maintain the translation from time to time?
You could also add a disclaimer at the beginning of the book to warns that the translation might not be up to date.

@Nadai2010
Copy link
Contributor

This sounds great, we have translated versions of the Starknet Book, Cairo Book and Dojo Book, in my case for Starknet in Spanish, thinking about the communities and having good translations in different languages.

The updates will depend in my case on the job I have at that time, I think that an update every 15 days could be fine

What do you think?

@cryptonerdcn
Copy link
Contributor Author

@cryptonerdcn Thank you a lot, this looks good to me. I'm unable to review and maintain any additional translations. Are you available to maintain the translation from time to time? You could also add a disclaimer at the beginning of the book to warns that the translation might not be up to date.

Yes, just like the Cairo Book? We update it 2 weeks ~ 1 month once.
Nadai and I are founders of [i18n]Starknet Translators(An open-source community). Just like he said, we have translated the Starknet Book, Cairo Book, and Dojo Book into Spanish, Chinese, and some other languages together.

@julio4
Copy link
Contributor

julio4 commented Dec 2, 2023

@cryptonerdcn @Nadai2010
I'm aware of your translation efforts and I can't thank you enough for it!
If you can maintain the translation of this book as well from time to time (~once per month is more than enough) it would be amazing.

Should I keep this PR open for some time or the initial translation is already done?

@cryptonerdcn
Copy link
Contributor Author

@julio4 If it is possible please merge this PR first.
I will open another PR when the full translation is completed.

@julio4 julio4 merged commit c965ae1 into NethermindEth:main Dec 4, 2023
@julio4 julio4 mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants