Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] translate Spanish #142

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[i18n] translate Spanish #142

merged 1 commit into from
Dec 6, 2023

Conversation

Nadai2010
Copy link
Contributor

Description

Hi team, i add translation version Spanish

@julio4 julio4 merged commit a0a087a into NethermindEth:main Dec 6, 2023
1 check passed
@julio4
Copy link
Contributor

julio4 commented Dec 6, 2023

LGTM! Thank you very much.
Please review my comments in #133 but I believe you have already.

@Nadai2010
Copy link
Contributor Author

Nadai2010 commented Dec 6, 2023

Hello @julio4 Sorry for not answering, I just only put 👍 in #133.

I agree to update the book every 15 - 30 days, if at any time you have a important update, you can tag us to know what is important and give priority if we can compared to the period of 15 to 30 days that we mentioned.

By the way: @cryptonerdcn or @julio4, I'm checking, did I miss any settings? I don't see the Spanish version added.

Very Thank you

@cryptonerdcn
Copy link
Contributor

@Nadai2010 Oh bro you should not touch zh-cn.po because it will break something.
You must add es to languages and UI to show the Spanish Version.
I will make a PR for this. @julio4

@Nadai2010
Copy link
Contributor Author

Normally I only upload the po.es, but when creating the language from 0, I did the pr to update the message.pot and I don't know why the po.ch was updated, I didn't touch anything there 😅, sorry @cryptonerdcn

@cryptonerdcn
Copy link
Contributor

Normally I only upload the po.es, but when creating the language from 0, I did the pr to update the message.pot and I don't know why the po.ch was updated, I didn't touch anything there 😅, sorry @cryptonerdcn

That's OK. Next time you can just commit es.po and reset zh-cn.po to default. It will work.

@Nadai2010
Copy link
Contributor Author

You're right, I'll be careful next time to not upload the rest of the changes. Thank you friend

@julio4
Copy link
Contributor

julio4 commented Dec 7, 2023

@cryptonerdcn @Nadai2010 Thank you both for the reactivity!

There's still an issue with the Spanish version @Nadai2010, where some parts are not translated well. Could you look into it?

@Nadai2010
Copy link
Contributor Author

Hi @julio4, I upload it in this PR #147, I don't know what happened but the file was broken, everything is corrected now.

Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants