Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor product versioning and revise Docker files #4781

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Refactor product versioning and revise Docker files #4781

merged 3 commits into from
Oct 20, 2022

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Oct 19, 2022

Refactors product versioning and fixes that for Docker images.

IMPORTANT! With this change, before branching a new release from the master branch, the product version must be bumped up in Directory.Build.props. The release Git tag must always match the version defined in Directory.Build.props.

Changes:

  • The product version is now hardcoded in Directory.Build.props
  • GitHub Actions and Docker files have been updated in accordance with the abovementioned change

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

The following scripts have been tested:

  • build-nethermind-docker-images.yml
  • build-nethtest-hive-docker-images.yml
  • run-nethermind-tests.yml

MarekM25
MarekM25 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked with @rubo and I'm okay with the change. However, I haven't verified the script, so let's wait for @FalcoXYZ review.

@FalcoXYZ
Copy link
Contributor

FalcoXYZ commented Oct 20, 2022 •
edited
Loading

@rubo did you test these changes? (talking about gh actions in specific)

@rubo
Copy link
Contributor Author

rubo commented Oct 20, 2022 •
edited
Loading

@FalcoXYZ Yes, I've tested but I modified them before testing to prevent publishing a new release here and there. If you're okay with the changes, I'll test it again but the full test will occur on the actual release.

@FalcoXYZ
Copy link
Contributor

Please test it locally (and confirm here it works) and add back everything that you removed for testing. I will review once you add it all back.

@rubo
Copy link
Contributor Author

rubo commented Oct 20, 2022

@FalcoXYZ There's nothing to add. Everything is in its place.

@FalcoXYZ
Copy link
Contributor

Where is the PPA or homebrew section in the release-nethermind.yml file?

@rubo
Copy link
Contributor Author

rubo commented Oct 20, 2022

Whoops! 😄 Sorry, refresh the page.

@FalcoXYZ
Copy link
Contributor

I've checked the Github Actions and Dockerfile, looks OK. I'm not familiar with the actual dotnet stuff so can't comment on that.
Good job on removing the "set-output" and changing it, as that will be deprecated soon.

@rubo rubo merged commit 9606343 into master Oct 20, 2022
@rubo rubo deleted the feature/version-refactor branch October 20, 2022 20:39
@rubo rubo mentioned this pull request Oct 21, 2022
Closed
kamilchodola pushed a commit that referenced this pull request Oct 21, 2022
@rubo @kamilchodola
Refactor product versioning and revise Docker files (#4781)
c40030b
LukaszRozmej added a commit that referenced this pull request Dec 6, 2022
@LukaszRozmej @rubo
@kamilchodola @jmederosalvarado @github-actions @OlegJakushkin @asdacap @MarekM25 @FalcoXYZ
Trace/db traces (#4535)
2e8630b 
* Implement TraceStore plugin

* Add compression to db

* Allow unsafe to avoid allocation

* Fix EndBlockTrace to be after Applying rewards

* Add ByteArrayPoolList

* Make ResettableList implement IReadOnlyCollection

* Make DbOnTheRocks default to nameless configuration if named not found

* Make BlockTracerBase based on ResettableList

* Fixes and improvements

* Add plugin to pipelines

* fix test

* Add temporary traces

* Revert "Add temporary traces"

This reverts commit 9190ed0.

* Add exception data to json rpc errors

* Increase MaxDepth to 128

* Refactor product versioning and revise Docker files (#4781)

* Upgrade version to 14.4 (#4796)

Co-authored-by: Kamil Chodoła <kamil@nethermind.io>

* Chiado TTD (#4801)

* Updating Fast Sync config files (#4803)

Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com>

* Feature: added extra data length checks (#4805)

* Added 32 bytes check on extra data

Added checks and tests for the ExtraData not to be longer than 32 bytes

* Fix workflow to pass parameters to scripts (#4799)

* Autorecover when disconnected chain is found (#4816)

* Autorecover when disconnected chain is found

* Fix tests

* Updating Fast Sync config files (#4819)

Co-authored-by: MarekM25 <MarekM25@users.noreply.github.com>

* Fix environment variable definition (#4825)

* Revert "Fix sepolia invalid block (#4694)" (#4838)

This reverts commit 8f28e4a.

* Bump build version to 14.5 (#4839)

Co-authored-by: Kamil Chodoła <kamil@nethermind.io>

* fix transition creation

* Don't log error, when initialization is stopped (like when syncing previously downloaded blocks from db)

* Add VerifySerialized option

* Add serialization tests

* Move VerifySerialized to TraceSerializer, add MaxDepth config

* fix whitespace

* fix null handling in TxBroadcaster

* Refactor ITraceSerializer

* fix test

* undo fix

* whitespace fix

* test fix

* fixes

* Set chiado and xdai `Merge.SecondsPerSlot=5` (#4880)

* Set chiado `Merge.SecondsPerSlot=5`

* Update xdai configs with `Merge.SecondsPerSlot=5`

This commit is not relevant before the merge.

* Updating Fast Sync config files (#4897)

Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com>

* Set C# version to 10.0 (#4881)

* Add gnosischain TTD value (#4901)

* Add gnosischain TTD value

Scheduled for `Dec 5 2022` assuming 5s block times: `8626000000000000000000058750000000000000000000`

* Add EnginePort xdai configs

* Add xdai TTD test to ChainSpecLoaderTests

* Fix runner tests

* Override MergePlugin Name and Description fields in AuRaMergePlugin

* fix eth_call mix_hash and beneficiary (#4873)

* fix eth_call mix_hash and beneficiary

* always set MixHash
# Conflicts:
#	src/Nethermind/Nethermind.Facade/BlockchainBridge.cs

* Changes the docker password to a token (#4916)

* fix: changes the docker password to token

* fix: update docker pass for main release workflow

* parallelized trace_filter execution per block

* Remove unneded filters

* Reduce traces memory allocation

* fix trace filtering

* fix whitespace

* Updating Fast Sync config files (#4920)

Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com>

* Bump build version to 14.6 (#4923)

Co-authored-by: Kamil Chodoła <kamil@nethermind.io>

* Changes the docker password variable to token (#4924)

* fix: changes the docker password to token

* fix: update docker pass for main release workflow

* fix: change DOCKER_PASSWORD to token

* null action result when it is empty

* Temporarily switch to `ubuntu-20.04` image (#4927)

* Ignore ParityResult.IsEmpty in JSON

* Fix remove empty results

* Merge 1.14.7

* fix licensing header

* fix whitespace

* Final touches

* Make ITraceSerializer generic

* refactor

* Adds IsTracingFees docs

* FIx issue when Result was added to json, because it was created by default on deserialization, even if not serialized

* fix shutdown if TraceStorePlugin not Enabled

* Review fixes

* Fix tests

* fix shitespace

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <43241881+kamilchodola@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Jorge Mederos <46798594+jmederosalvarado@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com>
Co-authored-by: Oleg Jakushkin <oleg.jakushkin@gmail.com>
Co-authored-by: Amirul Ashraf <asdacap@gmail.com>
Co-authored-by: MarekM25 <MarekM25@users.noreply.github.com>
Co-authored-by: Marek Moraczyński <marekm2504@gmail.com>
Co-authored-by: Falco <1364936+FalcoXYZ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@FalcoXYZ FalcoXYZ FalcoXYZ approved these changes

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubo @FalcoXYZ @MarekM25