Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gnosischain TTD value #4901

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Add gnosischain TTD value #4901

merged 5 commits into from
Nov 15, 2022

Conversation

jmederosalvarado
Copy link
Member

Scheduled for Dec 5 2022 assuming 5s block times: 8626000000000000000000058750000000000000000000

Changes:

  • Adds gnosischain TTD value

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe): config

Testing

Requires testing

  • Yes
  • No

@jmederosalvarado
Add gnosischain TTD value
787a009 
Scheduled for `Dec 5 2022` assuming 5s block times: `8626000000000000000000058750000000000000000000`
MarekM25
MarekM25 requested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Engine ports for xdai configs? No JsonRPC changes?
Check this PR: #4427

It looks like we missed for other chains, but could we add the test for TTD value: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Specs.Test/ChainSpecStyle/ChainSpecLoaderTests.cs

@LukaszRozmej
Copy link
Member

No Engine ports for xdai configs? No JsonRPC changes? Check this PR: #4427

It looks like we missed for other chains, but could we add the test for TTD value: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Specs.Test/ChainSpecStyle/ChainSpecLoaderTests.cs

We need to specify default engine port explicitly? Cannot it be something that is by default? (and enable based on Merge.Enabled)

@MarekM25 MarekM25 merged commit dbd501a into master Nov 15, 2022
@MarekM25 MarekM25 deleted the config/add_gnosis_ttd branch November 15, 2022 08:46
@MarekM25
Copy link
Contributor

No Engine ports for xdai configs? No JsonRPC changes? Check this PR: #4427
It looks like we missed for other chains, but could we add the test for TTD value: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Specs.Test/ChainSpecStyle/ChainSpecLoaderTests.cs

We need to specify default engine port explicitly? Cannot it be something that is by default? (and enable based on Merge.Enabled)

You could break backward compatibility with AdditionalRpcUrls Perhaps, we can find the solution, but someone should think more about all cases @smartprogrammer93 @deffrian know this topic

@smartprogrammer93
Copy link
Contributor

@LukaszRozmej as @MarekM25 said, either you need to specify AdditionalRpcUrls (as done in previous configs) or specify EnginePort. reason for this is that we wanted to not break backward compatibility with old config formats. We had to set the default value for EnginePort as null.

kamilchodola pushed a commit that referenced this pull request Nov 15, 2022
@jmederosalvarado @kamilchodola
Add gnosischain TTD value (#4901)
6f8b889 
* Add gnosischain TTD value

Scheduled for `Dec 5 2022` assuming 5s block times: `8626000000000000000000058750000000000000000000`

* Add EnginePort xdai configs

* Add xdai TTD test to ChainSpecLoaderTests

* Fix runner tests

* Override MergePlugin Name and Description fields in AuRaMergePlugin
This was referenced Nov 15, 2022
Merged
Closed
Merged
bors bot pushed a commit to sigp/lighthouse that referenced this pull request Nov 21, 2022
@dapplion @michaelsproul
Schedule gnosis merge (#3729)
e372953 
## Issue Addressed

N/A

## Proposed Changes

Schedule Gnosis merge
- Upstream config PR: gnosischain/configs#3
- Nethermind PR: NethermindEth/nethermind#4901
- Public announcement: https://twitter.com/gnosischain/status/1592589482641223682

## Additional Info

N/A

Co-authored-by: Michael Sproul <michael@sigmaprime.io>
@dapplion dapplion mentioned this pull request Nov 23, 2022
Merged
@Aracki
Copy link

Aracki commented Nov 29, 2022 •
edited
Loading

But are we gonna need to specify TerminalTotalDifficulty when running a Gnosis node with --config=xdai_archive or not?

@jmederosalvarado
Copy link
Member Author

But are we gonna need to specify TerminalTotalDifficulty when running a Gnosis node with --config=xdai_archive or not?

@Aracki no need to specify it

@yperbasis yperbasis mentioned this pull request Dec 6, 2022
Merged
yperbasis added a commit to erigontech/erigon that referenced this pull request Dec 6, 2022
@yperbasis
Gnosis Chain TTD (#6220)
5059ace 
See NethermindEth/nethermind#4901
LukaszRozmej added a commit that referenced this pull request Dec 6, 2022
@LukaszRozmej @rubo
@kamilchodola @jmederosalvarado @github-actions @OlegJakushkin @asdacap @MarekM25 @FalcoXYZ
Trace/db traces (#4535)
2e8630b 
* Implement TraceStore plugin

* Add compression to db

* Allow unsafe to avoid allocation

* Fix EndBlockTrace to be after Applying rewards

* Add ByteArrayPoolList

* Make ResettableList implement IReadOnlyCollection

* Make DbOnTheRocks default to nameless configuration if named not found

* Make BlockTracerBase based on ResettableList

* Fixes and improvements

* Add plugin to pipelines

* fix test

* Add temporary traces

* Revert "Add temporary traces"

This reverts commit 9190ed0.

* Add exception data to json rpc errors

* Increase MaxDepth to 128

* Refactor product versioning and revise Docker files (#4781)

* Upgrade version to 14.4 (#4796)

Co-authored-by: Kamil Chodoła <kamil@nethermind.io>

* Chiado TTD (#4801)

* Updating Fast Sync config files (#4803)

Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com>

* Feature: added extra data length checks (#4805)

* Added 32 bytes check on extra data

Added checks and tests for the ExtraData not to be longer than 32 bytes

* Fix workflow to pass parameters to scripts (#4799)

* Autorecover when disconnected chain is found (#4816)

* Autorecover when disconnected chain is found

* Fix tests

* Updating Fast Sync config files (#4819)

Co-authored-by: MarekM25 <MarekM25@users.noreply.github.com>

* Fix environment variable definition (#4825)

* Revert "Fix sepolia invalid block (#4694)" (#4838)

This reverts commit 8f28e4a.

* Bump build version to 14.5 (#4839)

Co-authored-by: Kamil Chodoła <kamil@nethermind.io>

* fix transition creation

* Don't log error, when initialization is stopped (like when syncing previously downloaded blocks from db)

* Add VerifySerialized option

* Add serialization tests

* Move VerifySerialized to TraceSerializer, add MaxDepth config

* fix whitespace

* fix null handling in TxBroadcaster

* Refactor ITraceSerializer

* fix test

* undo fix

* whitespace fix

* test fix

* fixes

* Set chiado and xdai `Merge.SecondsPerSlot=5` (#4880)

* Set chiado `Merge.SecondsPerSlot=5`

* Update xdai configs with `Merge.SecondsPerSlot=5`

This commit is not relevant before the merge.

* Updating Fast Sync config files (#4897)

Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com>

* Set C# version to 10.0 (#4881)

* Add gnosischain TTD value (#4901)

* Add gnosischain TTD value

Scheduled for `Dec 5 2022` assuming 5s block times: `8626000000000000000000058750000000000000000000`

* Add EnginePort xdai configs

* Add xdai TTD test to ChainSpecLoaderTests

* Fix runner tests

* Override MergePlugin Name and Description fields in AuRaMergePlugin

* fix eth_call mix_hash and beneficiary (#4873)

* fix eth_call mix_hash and beneficiary

* always set MixHash
# Conflicts:
#	src/Nethermind/Nethermind.Facade/BlockchainBridge.cs

* Changes the docker password to a token (#4916)

* fix: changes the docker password to token

* fix: update docker pass for main release workflow

* parallelized trace_filter execution per block

* Remove unneded filters

* Reduce traces memory allocation

* fix trace filtering

* fix whitespace

* Updating Fast Sync config files (#4920)

Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com>

* Bump build version to 14.6 (#4923)

Co-authored-by: Kamil Chodoła <kamil@nethermind.io>

* Changes the docker password variable to token (#4924)

* fix: changes the docker password to token

* fix: update docker pass for main release workflow

* fix: change DOCKER_PASSWORD to token

* null action result when it is empty

* Temporarily switch to `ubuntu-20.04` image (#4927)

* Ignore ParityResult.IsEmpty in JSON

* Fix remove empty results

* Merge 1.14.7

* fix licensing header

* fix whitespace

* Final touches

* Make ITraceSerializer generic

* refactor

* Adds IsTracingFees docs

* FIx issue when Result was added to json, because it was created by default on deserialization, even if not serialized

* fix shutdown if TraceStorePlugin not Enabled

* Review fixes

* Fix tests

* fix shitespace

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <43241881+kamilchodola@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Jorge Mederos <46798594+jmederosalvarado@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com>
Co-authored-by: Oleg Jakushkin <oleg.jakushkin@gmail.com>
Co-authored-by: Amirul Ashraf <asdacap@gmail.com>
Co-authored-by: MarekM25 <MarekM25@users.noreply.github.com>
Co-authored-by: Marek Moraczyński <marekm2504@gmail.com>
Co-authored-by: Falco <1364936+FalcoXYZ@users.noreply.github.com>
macladson pushed a commit to macladson/lighthouse that referenced this pull request Jan 5, 2023
@dapplion @michaelsproul @macladson
Schedule gnosis merge (sigp#3729)
826bd38 
## Issue Addressed

N/A

## Proposed Changes

Schedule Gnosis merge
- Upstream config PR: gnosischain/configs#3
- Nethermind PR: NethermindEth/nethermind#4901
- Public announcement: https://twitter.com/gnosischain/status/1592589482641223682

## Additional Info

N/A

Co-authored-by: Michael Sproul <michael@sigmaprime.io>
Andrew-Pohl pushed a commit to fuseio/nethermind that referenced this pull request Apr 18, 2023
@jmederosalvarado @Andrew-Pohl
Add gnosischain TTD value (NethermindEth#4901)
9f1d7dd 
* Add gnosischain TTD value

Scheduled for `Dec 5 2022` assuming 5s block times: `8626000000000000000000058750000000000000000000`

* Add EnginePort xdai configs

* Add xdai TTD test to ChainSpecLoaderTests

* Fix runner tests

* Override MergePlugin Name and Description fields in AuRaMergePlugin
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@dapplion @michaelsproul @Woodpile37
Schedule gnosis merge (sigp#3729)
e759a5e 
## Issue Addressed

N/A

## Proposed Changes

Schedule Gnosis merge
- Upstream config PR: gnosischain/configs#3
- Nethermind PR: NethermindEth/nethermind#4901
- Public announcement: https://twitter.com/gnosischain/status/1592589482641223682

## Additional Info

N/A

Co-authored-by: Michael Sproul <michael@sigmaprime.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

@dceleda dceleda Awaiting requested review from dceleda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmederosalvarado @LukaszRozmej @MarekM25 @smartprogrammer93 @Aracki