Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sending new single tx p2p update #6895

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Fix sending new single tx p2p update #6895

merged 3 commits into from
Apr 3, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Apr 2, 2024 •
edited
Loading

Fixes hive test Blob Transaction Ordering, Multiple Clients

Changes

  • Fix sharing of a new single blob tx over p2p

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

LukaszRozmej
LukaszRozmej approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use a test?

@flcl42 flcl42 force-pushed the bugfix/blob-txs-selection branch from 5321be7 to 7e7900c Compare April 3, 2024 09:21
@flcl42 flcl42 merged commit 3f7b552 into master Apr 3, 2024
67 checks passed
@flcl42 flcl42 deleted the bugfix/blob-txs-selection branch April 3, 2024 09:41
kamilchodola pushed a commit that referenced this pull request Apr 3, 2024
@flcl42 @kamilchodola
Fix sending new single tx p2p update (#6895)
056dc4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flcl42 @LukaszRozmej @marcindsobczak