Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery when offline on start #7223

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Discovery when offline on start #7223

merged 2 commits into from
Jun 27, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Jun 26, 2024

Fixes #7222

Changes

  • Does not mark unreachable if secondary ping succeed
  • Retries to connect to unreachable peers when goes online

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 changed the title Dscovery when offline on start Discovery when offline on start Jun 26, 2024
@flcl42 flcl42 force-pushed the bugfix/discovery-when-offline-on-start branch from 24d9ee1 to c53b64b Compare June 26, 2024 13:20
@flcl42 flcl42 marked this pull request as ready for review June 26, 2024 20:42
@flcl42 flcl42 merged commit 949589f into master Jun 27, 2024
68 checks passed
@flcl42 flcl42 deleted the bugfix/discovery-when-offline-on-start branch June 27, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@benaadams benaadams benaadams approved these changes

@asdacap asdacap Awaiting requested review from asdacap

@jmederosalvarado jmederosalvarado Awaiting requested review from jmederosalvarado

@ak88 ak88 Awaiting requested review from ak88

@deffrian deffrian Awaiting requested review from deffrian

@alexb5dh alexb5dh Awaiting requested review from alexb5dh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restart need to find peers
3 participants
@flcl42 @benaadams @LukaszRozmej