-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf/parallelize storage commit #7605
Conversation
…to perf/parallelize-storage-commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great, but due to large refactor I think code can be made more readable and there are quite a few possibilities to do that.
It is now confusing what is the difference, usage and purpose of TrieStore.GetTrieStore
and the difference between ITrieStore.BeginBlockCommit
and IScopedTrieStore.BeginCommit
. We either need better naming, or some documenting comments or both.
Also adjust doc comments where method parameters changed.
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing