Fix/broken storage after snap sync #7789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateSyncPivot
, originally wasPivot
specific for snap sync. When a storage healing was scheduled, the address to the storage is added toUpdatedStorages
in theStateSyncPivot
. This usually happens less than 100 times. During healing, once the root was scheduled for persist, the new storage root for each of these contract is checked for existence. If any of the root is missing, the missing storage root is queued for download through standard healing code path and therefore the rest of the missing storage tree will be downloaded.StateMin/MaxDistanceFromHead
did not account forFastSyncLag
which cause sync issue on network without CL.What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing